Undo opencascade positioning and rotation

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling

https://jupytercad.github.io/JupyterCAD

BSD 3-Clause "New" or "Revised" License

141 stars 18 forks source link

Undo opencascade positioning and rotation #580

Closed arjxn-py closed 21 hours ago

arjxn-py commented 1 week ago

Also fix #590

On main:

On this branch:

github-actions[bot] commented 1 week ago

Preview PR at appsharing.space

github-actions[bot] commented 1 week ago

Integration tests report: appsharing.space

martinRenou commented 1 week ago

Just rebased from the UI

arjxn-py commented 1 week ago

Only exploded view is broken now

arjxn-py commented 3 days ago

Everything seems right just newGeometryCenter:

this branch:

main:

martinRenou commented 1 day ago

It is starting to look correct!

The UI-tests failure looks legit.

First issue:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'Position') when trying to open the step file and stl file examples. We need to default the placement somewhere in the code

Second issue:

The Cone of test.jcad looks broken if we rotate it a bit more. This may have to do with rotation of vertices.

https://github.com/user-attachments/assets/c3f1da7d-4150-4f5f-a497-8af1672b8501

arjxn-py commented 21 hours ago

Please update snapshots 🌮

martinRenou commented 21 hours ago

bot please update snapshots!