jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
105 stars 101 forks source link

Cleanup the UI to be much nicer #78

Closed yuvipanda closed 5 months ago

yuvipanda commented 5 months ago

Built on top of https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/77

image

This PR is a combination of JS cleanup as well as UI cleanup.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a binder notebook on this branch for commit c7937830d03ecd4e35e2e478d8d8fc6de3cdf7bb

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 0faedee6b255080a1dba60ae87458b8a45388279

Binder :point_left: Launch a binder notebook on this branch for commit 0e938ce1c2699557d25e19530289282ebc504362

Binder :point_left: Launch a binder notebook on this branch for commit ee058cf03c42ed1fff97d6d67a99aa5814eb185e

Binder :point_left: Launch a binder notebook on this branch for commit ac8c768cec254dd777574d7e8e00290bf08ea25b

Binder :point_left: Launch a binder notebook on this branch for commit b47a85d03daf38c584f06772a56d6c26c2d0a863

Binder :point_left: Launch a binder notebook on this branch for commit 0d9747ec361254677d2c01ebecb2355fa37c85da

Binder :point_left: Launch a binder notebook on this branch for commit d4c92235864c54e29f9fcf2b204cda19e62e6752

Binder :point_left: Launch a binder notebook on this branch for commit 651cb08d2a5c7145daf63944716baafa8736158a

Binder :point_left: Launch a binder notebook on this branch for commit 408a4fc57028b5b136cd22f0db0a4c3d5f1ed028

Binder :point_left: Launch a binder notebook on this branch for commit efecd5ee99ae297944ca4d3557fbfb0adedec1e0

Binder :point_left: Launch a binder notebook on this branch for commit 7c288722f7a0e94da1b20ab214d2034d1515e890

Binder :point_left: Launch a binder notebook on this branch for commit 4d1a878467f32fd8af0d0c835ca41de9d9a6a573

Binder :point_left: Launch a binder notebook on this branch for commit a0184355fe5739b9f6250ed4ab85229b0cd54e6e

Binder :point_left: Launch a binder notebook on this branch for commit b1a264dcff79523dd74977964455f62385a2276a

yuvipanda commented 5 months ago

I wanna move js to src but that's likely to cause a bunch of knock on effects in #79 so I'll do that after.

manics commented 5 months ago

Looks nice! I'm unsure about removing Ctrl-Alt-Del, I've had to use it a few times but can't remember why. It could be hidden in a menu though if you don't want it too visible? Or perhaps make the Jupyter logo a dropdown menu?

yuvipanda commented 5 months ago

@manics when I tried it, it showed me the logout window. And if I tried to logout, it mostly just bricked my desktop session - I think it stopped dbus and xfce-session, but not anything else. That's one of the primary reasons I removed it, as our handling of how these processes are supervised (they just double fork and go on their merry way) doesn't help.

I'm going to add a dropdown menu with lesser used options - primarily intended for a checkbox for 'scale to fit'. But I can put a ctrl-alt-delete button there too. Are you ok with that coming in a later PR?

yuvipanda commented 5 months ago

Yay, thank you, @manics :)