jupyterhub / jupyter-remote-desktop-proxy

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
105 stars 101 forks source link

Fix TigerVNC detection for non-apt installations #96

Closed consideRatio closed 4 months ago

consideRatio commented 4 months ago

I think we checked the case sensitive TigerVNC string which works if TigerVNC was installed via apt, but may not work when installed in another way. On the other hand, at those times, checking for the case insensitive string would work then. So, this PR makes the check case insensitive.

Thank you @goekce for your thorough issue report!!

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a binder notebook on this branch for commit 2896efa48e053d3fc59ad9f79f121ffbb9017991

I will automatically update this comment whenever this PR is modified

consideRatio commented 4 months ago

Does this look right to you @goekce?

goekce commented 4 months ago

I could not test on an installation due to lack of capacity right now.

I believe the command line arguments to tigervnc and turbovnc may be different. In #69 I had mentioned that -xstartup is not accepted by tigervnc:

https://github.com/jupyterhub/jupyter-remote-desktop-proxy/blob/024ab7d61dbe403dc10b090bde4eb2239b030d8e/jupyter_remote_desktop_proxy/__init__.py#L34-L35

I searched for but could neither find any reference to xstartup in the source code of tigervnc nor in the documentation:

https://github.com/search?q=repo%3ATigerVNC%2Ftigervnc%20xstartup&type=code

Further arguments must also be tested:

https://github.com/jupyterhub/jupyter-remote-desktop-proxy/blob/024ab7d61dbe403dc10b090bde4eb2239b030d8e/jupyter_remote_desktop_proxy/__init__.py#L37-L46

This is the reason why I think in the long term the arguments should be configurable by the user.

consideRatio commented 4 months ago

Thank you @goekce, I opened #98 to represent that - let's go for a merge on this bug for now. I'll try to get it all the way so there is actual turbovnc support as we've commited to have.

consideRatio commented 4 months ago

Thank you for reviewing @yuvipanda and @goekce!!