Closed consideRatio closed 4 months ago
Does this look right to you @goekce?
I could not test on an installation due to lack of capacity right now.
I believe the command line arguments to tigervnc and turbovnc may be different. In #69 I had mentioned that -xstartup
is not accepted by tigervnc:
I searched for but could neither find any reference to xstartup
in the source code of tigervnc nor in the documentation:
https://github.com/search?q=repo%3ATigerVNC%2Ftigervnc%20xstartup&type=code
Further arguments must also be tested:
This is the reason why I think in the long term the arguments should be configurable by the user.
Thank you @goekce, I opened #98 to represent that - let's go for a merge on this bug for now. I'll try to get it all the way so there is actual turbovnc support as we've commited to have.
Thank you for reviewing @yuvipanda and @goekce!!
I think we checked the case sensitive TigerVNC string which works if TigerVNC was installed via
apt
, but may not work when installed in another way. On the other hand, at those times, checking for the case insensitive string would work then. So, this PR makes the check case insensitive.Thank you @goekce for your thorough issue report!!