Fix nbgrader installation and configure correctly for nbgrader>=0.5.0

jupyterhub / jupyterhub-deploy-teaching

Reference deployment of JupyterHub and nbgrader on a single server

http://jupyterhub-deploy-teaching.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

246 stars 85 forks source link

Fix nbgrader installation and configure correctly for nbgrader>=0.5.0 #83

Closed thotypous closed 6 years ago

thotypous commented 7 years ago

This pull request fixes the following issues:

Currently, nbgrader is installed to /tmp/src, therefore it is lost and stops working if the server is rebooted.
The nbgrader role installs from git (master branch), however all the config files seem to be generated with version 0.4.0 in mind. Here we adopt the new configuration scheme for nbgrader>=0.5.0.

Please note that I'm a newcomer to jupyterhub, so I expect feedback --- this surely is not a well-polished patch. For example, I have no idea on how to get nbgrader working with multiple graders in this new configuration scheme.

minrk commented 7 years ago

I'm fine with this update, but I don't have the right experience to confirm that it's all correct. I'd love to get an OK from @jhamrick or @ellisonbg .

thotypous commented 7 years ago

@minrk Thanks for the review! @jhamrick Thanks for review and the pointers!

I am a little overwhelmed for the next few weeks, so I do not know if I will be able to implement it the way @jhamrick proposed. If anybody wants to take over this issue in the meantime, please feel free.

boersmamarcel commented 7 years ago

@thotypous thanks for the fixes, I ran into similar problem and using this open merge request resolved them. Although I was required to register the nbgrader plugin using

jupyter nbextension install --sys-prefix --py nbgrader --overwrite
jupyter nbextension enable --sys-prefix --py nbgrader
jupyter serverextension enable --sys-prefix --py nbgrader

There is only one problem and I'm not sure if it is a separate issue or belongs in this merge request. After creating assignments and releasing them to the exchange directory I was unable to fetch the assignments for the students. Do you have any suggestions to resolve this? There are no error messages or whatsoever so I'm a bit clueless here. I'm using pretty much the standard config as provided in hostname.example but with nbgrader set to true.

@thotypous I might be able to help out with incorporating the suggestions of @jhamrick although I'm not an expert in jupyterhub as well but would love to learn!

jhamrick commented 6 years ago

[Catching up on issues and PRs as I've been away for the last two months]

@boersmamarcel Did you fetch using the web interface, or on the command line? If in the web interface, in what way did it fail (e.g. can you post a screenshot)? And can you also check the javascript console for errors?

jhamrick commented 6 years ago

I have updated the nbgrader documentation to provide more examples of how to use it with JupyterHub if that helps with this PR: http://nbgrader.readthedocs.io/en/latest/configuration/jupyterhub_config.html

ellisonbg commented 6 years ago

Thanks for this PR - it was definitely in the right direction. I am going through the repo and updating everything to work with JupyterHub 0.8.x, JupyterLab, and nbgrader latest (>=0.5). As of my latest PR #96 it seems to all be working. I will be updating the docs as well.

The only thing that isn't automated in the ansible config is multiple graders/instructors for a single course. My initial thought is to document how to do it, but not try to automate all the complexity. I will open a separate issue for that.

Closing this PR as I everything is now fixed in master, but many thanks for getting this going!!!