jupyterhub / jupyterhub-sphinx-theme

A lightweight wrapper theme for Sphinx based on the PyData Sphinx Theme
https://jupyterhub-sphinx-theme.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Fix html_logo not being respected #13

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

When html_logo was set, it was ignored because our theme defaulted to configure html_theme_options related to logo that was granted a higher priority by pydata_sphinx_theme.

With this change, we end up not providing the high-priority default if the low-priority html_logo is configured.

This enables https://github.com/jupyterhub/mybinder.org-deploy/pull/2674 to work without switching away from jupyterhub-sphinx-theme to the pydata theme.