search

jupyterhub / nbgitpuller

Jupyter server extension to sync a git repository one-way to a local path
https://nbgitpuller.readthedocs.io
BSD 3-Clause "New" or "Revised" License
205 stars 84 forks source link

Forward query string when redirecting from /git-pull/ endpoint #303

Open frankier opened 1 year ago

frankier commented 1 year ago

Fixes: #290

I've been having trouble with the redirect on BinderHub when 3rd party cookies are disabled. This fowards the token query string argument which seems to fix the issue.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 1 year ago

I'd like to review and help this PR, but I'm not confident on the situation you look to resolve based on the PR description.

Can you describe example links where nbgitpullers behavior will changed with this PR?

frankier commented 1 year ago

In Chrome/Chromium you should encounter this on BinderHub, when you disable 3rd party cookies. Do you happen to have a spare BinderHub nbgitpuller link handy?

2023-04-12T12-33-04

frankier commented 1 year ago

Old / does not work with 3rd party cookies disabled:

https://mybinder.org/v2/gh/frankier/duckbook/oldnbgitpuller?urlpath=git-pull%3Frepo%3Dhttps%253A%252F%252Fgithub.com%252Ffrankier%252Fcran_licenses%26branch%3Dmain

New / based on this PR

https://mybinder.org/v2/gh/frankier/duckbook/main?urlpath=git-pull%3Frepo%3Dhttps%253A%252F%252Fgithub.com%252Ffrankier%252Fcran_licenses%26branch%3Dmain

manics commented 1 year ago

Would you say this is primarily a mybinder.org issue that could affect other applications/extensions?

Can you open your browser debug/log console, and show us all the network requests and logs for a failing redirect?

frankier commented 1 year ago

I'm having some trouble generating working example links here because the link generator is still broken for me.

For me, the link generator is still not working. See also: https://github.com/jupyterhub/nbgitpuller/pull/297

frankier commented 1 year ago

As requested...

2023-04-13T13-48-57

The above links are finally fixed now. It might be enough to use an incognito window for testing. For me, one works and one does not.

P.S.: Click them while they're warm(!) ;)

P.P.S: I think this might affect other BinderHub instances? I'm not sure about other cases.

frankier commented 1 year ago

Hi! Were either of you able to replicate from my description?