search

jupyterlab-contrib / jupyterlab-topbar

JupyterLab Top Bar extensions
BSD 3-Clause "New" or "Revised" License
108 stars 17 forks source link

Migrate to jupyter-ui-toolkit for Switch component #127

Open mahendrapaipuri opened 4 months ago

mahendrapaipuri commented 4 months ago

Fixes #124

@jtpio I had some time to look at it. Let me know your thoughts!

mahendrapaipuri commented 4 months ago

Here is the binder link to test the PR -> https://mybinder.org/v2/gh/mahendrapaipuri/jupyterlab-topbar/use_jupyter_ui_components

jtpio commented 4 months ago

Also the theme name used to be "inside" the switch component:

image

Not sure there is a way to do this with the component from jupyter-ui-toolkit? And maybe we should remove the "Theme" label so it takes less space?

image

mahendrapaipuri commented 4 months ago

Also the theme name used to be "inside" the switch component:

image

Not sure there is a way to do this with the component from jupyter-ui-toolkit? And maybe we should remove the "Theme" label so it takes less space?

image

Yeah, there is no native way to embed labels inside the Switch component. Not sure if it is worth customizing the component. Maybe it makes more sense to address this issue in jupyter-ui-toolkit?