search

jupyterlab-contrib / jupyterlab-topbar

JupyterLab Top Bar extensions
BSD 3-Clause "New" or "Revised" License
108 stars 17 forks source link

Add support for other themes #94

Open jtpio opened 1 year ago

jtpio commented 1 year ago

Transferring https://github.com/jtpio/jupyterlab-theme-toggle/issues/3 here in this repo.

For now the theme toggle extension only support the dark and light themes:

https://github.com/jupyterlab-contrib/jupyterlab-topbar/blob/4eb59bc966d099f39d1aadad8bd47c63899b7d89/packages/theme-toggler-extension/src/index.tsx#L90-L93

However this could be made configurable via the settings system.

mahendrapaipuri commented 1 year ago

How do you envision this? Changing to sort of dropdown component and letting users to configure more than two themes or still use toggler component where users can configure two themes at a given time?

jtpio commented 1 year ago

Since there is already the possibility to choose from a list of themes via the Settings menu, maybe limiting the toggle to 2 options would make sense?

End users would go to the settings editor to enter the names of the two themes they would like to use.