search

jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
661 stars 43 forks source link

Should we keep the auto publication? #48

Closed fcollonval closed 2 years ago

fcollonval commented 2 years ago

I am not a big fan of the auto publication feature. We may want to merge multiple PRs before releasing a new feature. And more importantly we may want to control what should be the future version (this is not gonna be a new patch version each time). So I propose to update the current workflow file to react on workflow_dispatch (aka manual trigger) with the level of version update we want.

What do you think @axelfahy @ianhi ?

if we agree I take that opportunity to fix the npm publication too.

axelfahy commented 2 years ago

Ok for me, we don't need an auto publication at each merge. A manual trigger or trigger from a tag should be enough.

ianhi commented 2 years ago

Definitely agree!