jupyterlab-contrib / jupyterlab-vim

Vim notebook cell bindings for JupyterLab
https://jupyterlab-contrib.github.io/jupyterlab-vim.html
MIT License
661 stars 43 forks source link

Add configuration to provide custom keybindings #74

Closed peytondmurray closed 1 year ago

peytondmurray commented 1 year ago

Summary

This PR allows the user to configure custom Vim-mode keybindings using the advanced settings editor, closing #43.

@mlucool I tested binding m in normal mode to :noh<CR>, and that seems to work. CodeMirror cannot fully emulate Vim, and many keys will collide with browser or JupyterLab keybindings, so for example if you try to bind a command to <Ctrl-/> it will not work. In any case marks are not supported in CodeMirror so m in normal mode should work just fine.

Changes

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on branch peytondmurray/jupyterlab-vim/custom-keybindings

krassowski commented 1 year ago
error playwright@1.29.2: The engine "node" is incompatible with this module. Expected version ">=14". Got "12.22.12"

I would go ahead and drop node 12, it is EOL. Let's add node 16 or 18 to the matrix instead.

krassowski commented 1 year ago

Looking at Node.js 18 build failure, maybe we should try with 16 for now?

peytondmurray commented 1 year ago

Looks like node 16 works, thanks for the commit!