jupyterlab / jupyterlab-desktop

JupyterLab desktop application, based on Electron.
BSD 3-Clause "New" or "Revised" License
3.76k stars 365 forks source link

Comment shortcut on MacOS Latin-American layout #671

Open notluquis opened 1 year ago

notluquis commented 1 year ago

Description

Command shortcut doesn't work on Latin-American layout.

Reproduce

  1. Select or click the line to comment
  2. Press Ctrl + /, or Ctrl + #, or cmd + / or cmd + #
  3. No line commented.

Expected behavior

Comment the selected or selected lines.

Context

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

mbektas commented 1 year ago

@itsluquis can you retry with the latest version? There were several Electron.js upgrades that could resolve this issue as well.

notluquis commented 1 year ago

@mbektas Hi, the problem still persist. I can't comment the lines. Is there an option to manually set the keyboard shortcut? (Jupyter Desktop 4.0.5-1, Python 3.11.5, Jupyter Lab 4.0.5)

mbektas commented 1 year ago

@notluquis I am not aware of a way of customizing the comment toggle keyboard shortcuts. @JasonWeill any ideas if JupyterLab allows customizing this shortcut?

JasonWeill commented 1 year ago

You can customize shortcuts in the Advanced Settings Editor in JupyterLab. More info here: https://jupyterlab.readthedocs.io/en/latest/user/interface.html#keyboard-shortcuts

mbektas commented 11 months ago

@notluquis were you able to customize the comment shortcut using the link Jason shared?