Duplication in "manage python environments"

jupyterlab / jupyterlab-desktop

JupyterLab desktop application, based on Electron.

BSD 3-Clause "New" or "Revised" License

3.76k stars 366 forks source link

Duplication in "manage python environments" #787

Closed Bobson1729 closed 8 months ago

Bobson1729 commented 9 months ago

I have duplication in "manage python environments". I am not sure this is an issue with Jupyterlab Desktop, JupyterLab, miniconda, or something else.

Thanks for your help!

welcome[bot] commented 9 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

JasonWeill commented 9 months ago

If you open a conda-enabled command prompt (e.g., Miniconda command prompt on windows), and you run conda env list, what do you see?

mbektas commented 8 months ago

@Bobson1729 did you create any environments using JupyterLab Desktop? If so, did you use conda or venv type?

Bobson1729 commented 8 months ago

I didn't manually create any environments. The only one I have is "base" from miniconda. I installed Jupyterlab and Notebook from conda (conda-forge), and JLD via windows install.

All the duplicate environments in JLD environments all point to the exact same location (which is the base environment) and when I set one of them to default, they all say "default" .

conda env list only shows the base environment as well.

I did many reinstalls of jupyterlab, jupyter notebook, and jld to try and get the install right.

Is there a config file somewhere which lists the environments found by jld? Perhaps this just didn't clean up old info and every reinstall just added to this file instead of replacing it?

Again, thanks for your help!

mbektas commented 8 months ago

thanks for the in @Bobson1729 . The issue is caused by multiple discoveries of the same environment and deduplication not working properly. this change must have caused it. I will work on a solution. other than showing duplicate entries, this shouldn't cause any real issues. are you having any problems launching JupyterLab sessions?

environments are stored in application data file, but even if you delete the duplicate entries, app will rediscover and reduplicate at next launch.

Bobson1729 commented 8 months ago

Thanks! No issues with the functionality.

mbektas commented 8 months ago

hi @Bobson1729 , I implemented a fix for this issue. could you test it using the PR build output here before I publish it.

Bobson1729 commented 8 months ago

I would love to help, @mbektas , but I'm afraid I don't know how. I am very much a beginner here. Is there a way that you can compile a new "JupyterLab-Setup-Windows-x64.exe" installer for me?

mbektas commented 8 months ago

@Bobson1729 the link I shared (scroll to bottom to Artifacts section) had a link to latest installer with the fix. you can download and extract it and install. thanks!

Bobson1729 commented 8 months ago

@mbektas Got it. Works great!

mbektas commented 8 months ago

thanks for testing @Bobson1729 !