Closed ichasepucks closed 3 years ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
The pr you mention was merged for the 2.0 milestone.
And confirming, the merge commit (https://github.com/jupyterlab/jupyterlab/commit/3d1e5ee94a2df3978018fe632217ad8a66675e28) is in 2.0, and not in the 1.x series.
Thanks. Will consider forking 1.2 or monkey patching if I can figure out how to do it.
In case anyone else wants to do this, it turns out, it does work in the 1.2.20 version but is vastly different from the docs. Created a file called page_config.json
with the following contents:
{
"buildCheck": false,
"buildAvailable": false
}
Copied this file into the /opt/conda/share/jupyter/lab/settings
directory and it worked.
Description
Following along with https://github.com/jupyterlab/jupyterlab/pull/7381 indicates I should be able to disable the Build Check on first load. We package a version of JL with several custom extensions built in. When deployed to production we are seeing calls to
lab/api/build?1626307186716 (172.16.11.39) 21581.01ms
which are taking a very long time to complete.@bollwyvl can you help set an expectation on this behavior as documented https://jupyterlab.readthedocs.io/en/stable/user/directories.html#disabling-rebuild-checks? Do note the JL 1.2.20 version. I have tried to look through the code and see it in different places depending on the branch. Can you confirm if this should be in the 1.2.x branch or not?
Reproduce
c.LabApp.tornado_settings = {'page_config_data': {'buildCheck': 'False', 'buildAvailable': 'False'}}
to jupyter_notebook_config.py and ensure it is in config pathjupyter lab
Expected behavior
No calls to
/lab/api/build
should occur when disabledContext
Configuration dump shows this should be loaded in the LabApp tornado_settings.
Troubleshoot Output