jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
14.52k stars 3.56k forks source link

Resolved version of `@typescript-eslint/typescript-estree` does not support TypeScript 5.5 #17335

Open krassowski opened 1 month ago

krassowski commented 1 month ago

Description

Resolved version of @typescript-eslint/typescript-estree does not support TypeScript 5.5

Reproduce

  1. Run jlpm lint
  2. See warning
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.5.4

Please only submit bug reports when using the officially supported version.

=============

Expected behavior

No warning

Context

jtpio commented 1 month ago

Thanks @krassowski for the report.

Interestingly, the warning is displayed when running jlpm eslint but not with jlpm eslint:check. Which could explain why it does not show up in this lint run on CI: https://github.com/jupyterlab/jupyterlab/actions/runs/13481202709/job/37666605652

Regardless, updating to a newer @typescript-eslint/typescript-estree should hopefully help fix it.

jtpio commented 1 month ago

Regardless, updating to a newer @typescript-eslint/typescript-estree should hopefully help fix it.

There are some breaking changes in the last two major versions that would likely require some adjustments here: