jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
598 stars 127 forks source link

Descriptive aria-labels for Keyboard shortcuts which include punctuation previously ignored by screen readers #666

Open e218736 opened 6 months ago

e218736 commented 6 months ago

References

Issue 15497 - Screen reader doesn't read all keyboard shortcut punctuation When using screen reader (Windows Narrator) and navigating through the top menubar/command palette some punctuation is not announced. Keyboard shortcuts being read out incorrectly may be confusing/misleading for users of assistive technologies. This PR ensures that aria labels include descriptive text for punctuation used within default keyboard shortcuts so that the screen reader will announce correctly.

Code changes

User-facing changes

none visible. For screen reader users, keyboard shortcuts that include punctuation will be announced by default when focused.