search

jure / aframe-blink-controls

A teleport (blink with rotation) component for A-Frame
https://jure.github.io/aframe-blink-controls
MIT License
50 stars 17 forks source link

Simple addition of the snapturn function #1

Closed msitarzewski closed 3 years ago

msitarzewski commented 3 years ago

This code is based on https://github.com/aframehacknight/gravityglove by @aframehacknight

jure commented 3 years ago

Hey, thanks for this Michael! I'll be working on the final small fixes of this soon, and was wondering if it's OK with you if I cherry pick your commit into my own branch (the commit remains as it is, with name, attribution, etc.), so I can play around/change it easily?

I'm thinking of wrapping this up together with a change in teleport activation - had a discussion with @msub2 just now about how the activation of the teleport should ideally work (by default, that is) and I agree with @msub2 that it shouldn't require a thumbstick press by default, just a forward thumbstick axis to activate.

msitarzewski commented 3 years ago

100% - it’s yours now :) Looking forward to seeing how it works out. If you use any of my code for anything other than an idea I’ll be stoked. :)

That’s the way my existing teleport works. Just an up press. It’ll be interesting to see how you make that and setting the direction of the land work together!

On Jan 1, 2021, at 6:46 PM, Jure Triglav notifications@github.com wrote:

 Hey, thanks for this Michael! I'll be working on the final small fixes of this soon, and was wondering if it's OK with you if I cherry pick your commit into my own branch (the commit remains as it is, with name, attribution, etc.), so I can play around/change it easily?

I'm thinking of wrapping this up together with a change in teleport activation - had a discussion with @msub2 just now about how the activation of the teleport should ideally work and I agree with @msub2 that it shouldn't require a thumbstick press by default, just a forward thumbstick axis to activate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jure commented 3 years ago

Closing in favor of #3, thanks @msitarzewski!