search

jure / aframe-blink-controls

A teleport (blink with rotation) component for A-Frame
https://jure.github.io/aframe-blink-controls
MIT License
50 stars 17 forks source link

Allow the user to opt-out of rotating on teleport #13

Closed AdaRoseCannon closed 2 years ago

AdaRoseCannon commented 2 years ago

Allow the user to opt out of rotating when they teleport which is useful for devices without a joystick.

Fixes #11 Fixes #12

jure commented 2 years ago

Seems like a sensible request and sensible implementation! The only thing I'm confused about is the eslint and webpack upgrades mushed in there :) But given that those are welcome changes on their own - I don't see much of a reason to make a fuss about it.

LGTM.

jure commented 2 years ago

Thank you, @AdaRoseCannon!

AdaRoseCannon commented 2 years ago

I upgraded them because it wouldn't build without the upgrades. Thanks for merging it so quickly I appreciate it.