search

jure / aframe-blink-controls

A teleport (blink with rotation) component for A-Frame
https://jure.github.io/aframe-blink-controls
MIT License
50 stars 17 forks source link

Fix RAD2DEG undefined with threejs r144 #22

Closed vincentfretin closed 1 year ago

vincentfretin commented 1 year ago

With aframe master threejs r144, the page crashes when trying to teleport because THREE.Math doesn't exist anymore, we now need to import from THREE.MathUtils This change is still compatible with aframe 1.2.0.

I didn't see this error when I did #20 because I still had the <script>THREE.Math = THREE.MathUtils;</script> hack in my page.

vincentfretin commented 1 year ago

@jure When you have some time, please merge, do the build and a bugfix release 0.4.2. I'll try to update aframe-xr-boilerplate with all the latest versions (released versions or jsdelivr gh urls) in a few days.

jure commented 1 year ago

Thank you @vincentfretin!