jurialmunkey / plugin.video.themoviedb.helper

GNU General Public License v3.0
199 stars 95 forks source link

The speed on the android devices is very slow #617

Closed Bequiet19 closed 2 years ago

Bequiet19 commented 2 years ago

First I would like to thank you for this great addon. I've been using it on my PC for a long time. However, it doesn't work properly on Android devices. Opening any list is sometimes a big torture. Waiting sometimes 20 seconds to open the list. Especially if I turn on to uses fanart images.................. I have tried on several android devices with different configurations and the same thing. Let's say some other addons open lists quickly, especially elementum that opens almost instantly. I know that the addons in python are not speed champions, but is there any chance that the opening lists on Android devices will speed up a bit. Thanks in advance.

jurialmunkey commented 2 years ago

Don't turn on fanarttv or extra details.

jurialmunkey commented 2 years ago

Specifically these options will slow down loading for new items that haven't been cached yet (from most expensive to least expensive)

  1. API Keys > Use fanart.tv (all options)
  2. General > Get additional details and artwork from TMDb
  3. Accounts > Get watched indicators from Trakt
  4. General > Get additional details from local Kodi library database

FanartTV is a slow website, and if you don't have a VIP key it is even slower (sometimes a request can take upwards of ~800ms).

TMDb is faster. However, even on a fast machine (i7+SSD+Cable), the python requests module still logs a ~400ms return for a single request to the TMDb API. So just for one list, TMDb details adds 20 requests and since cheap android sticks suck at multithreading that's going to be at least 8 seconds where TMDbHelper is just waiting for the data from the website.

Add fanart.tv on top of that with a non-VIP account and it's pretty easy to see how you hit 20 seconds for a list of 20 items on a cheap android stick.

I can't make the python requests module go faster or your cheap Android stick be better at multithreading... And it's simply not possible to compete against binary blob executables compiled for specific platforms like Elementum does.

Bequiet19 commented 2 years ago

@jurialmunkey When I said I’ve tried on multiple android devices I didn’t just mean cheap android sticks. I tried both on a tablet and a mobile phone with quite serious configurations. Simply opening the list is far slower than on a PC. But ok if you say nothing can be done. I'm sorry about that since I thought I'd use tmdb helper on android. But at speeds like this, I'll get around it. It definitely stays on the pc.

jurialmunkey commented 2 years ago

Like I said, the number one issue is the speed of requests. Just a pure request to TMDb website via python requests module is ~400ms round trip at the best of times. If we take a realistic average of 500ms per request then that's 8 seconds on a 20 item list just for TMDb data.

On a PC, the cpus support multithreading so the requests can run in a parallel which significantly speeds things up because we aren't wasting time idling waiting for the data to return. However, on a mobile device, the cpu is geared towards battery life and typically doesn't support multithreading, so the requests are forced to happen in series one at a time instead.

It's the type of cpu in use not the Android platform per se. It doesn't matter how powerful the cpu is, if it can't process parallel threads then it's going to have to sit and wait for the server to respond with the data for each call before it moves onto the next instruction. Processing power can't make a server provide a request faster.

There are ways to handle these types of scenarios better on mobile devices but not with standard Python modules.

Bequiet19 commented 2 years ago

@jurialmunkey I understand everything. It's just a shame it's like that. We all know that android is being used more and more for kodi. But at speeds like this, it really seems useless.

Bequiet19 commented 2 years ago

@jurialmunkey My dear friend, I found an addon (Fen) based on python that is lightning fast when opening all lists. With all included metadata and fanart images it opens up almost everything instantly (on pc and android devices). So far I've tried many similar addons but none are as fast to open lists as this one (not even the elementum). I don't know how this was achieved. I'd like to see if it's possible to do it the same with our beloved tmdb helper. Thank you in advance. https://github.com/Tikipeter/repository.tikipeter

Bequiet19 commented 2 years ago

@jurialmunkey Did you maybe check out this addon I sent you? Is there a chance to get it at this speed in tmdb helper? I think this kind of acceleration would significantly improve such a good addon as tmdb helper.

jurialmunkey commented 2 years ago

That add-on doesn't get anywhere close to the same amount of metadata that TMDbHelper does.

I gave it a quick test and it didn't seem that much faster than TMDbHelper to me. It is definitely quicker but not massively so.

~Also, from a quick look at the code, it only does Fanart TV lookups IF the item do not have poster/fanart available on TMDb. Since TMDb nearly always has artwork, that means Fen is basically never looking up Fanart TV. I would expect that if you disable FanartTV in TMDbH you will probably get comparable performance~ Actually even with fanarttv forced it is quite fast on that side of things which I have no idea how it is managing to do that.

Without knowing what exactly is causing slow downs on your system though, there is no way to know what exactly it is doing differently that would result in a speed gain for you. I can't just rewrite the entire plugin - there is is a massive amount of code involved.

ambulancePilot commented 2 years ago

Sorry to comment here. If I disable the fanart settings you mentioned above, what exactly will I be missing? Does clearart come from fanart.tv or TMDB?

jurialmunkey commented 2 years ago

Sorry to comment here. If I disable the fanart settings you mentioned above, what exactly will I be missing? Does clearart come from fanart.tv or TMDB?

TMDb provides posters, fanart, landscape, clearlogo FanartTV provides posters, fanart, landscape, clearlogo, banners, characterart, clearart, discart.

You should only really need to enable fanarttv if you need clearart. If you use a skin that utilises the service monitor (e.g. Arctic Horizon) then you can get away with only enabling fanarttv for the service monitor.

By only enabled fanarttv for service and disabling it for plugin/widget paths, you'll get clearart "on the fly" for the focused item but the plugin directories will load faster because they're not being forced to lookup the fanarttv artwork of every item first.

Also the service monitor caches the details it looks up, so next time plugin directory loads that particular item the cached artwork details will automatically be attached directly to the item.

jurialmunkey commented 2 years ago

@ambulancePilot @Bequiet19 - In latest git version (v4.5.8) I've add a timer logging function to allow you to benchmark what is causing slow downs. You can enable it TMDbHelper Settings > Expert > Log timer reports for directories (it's just below the "Delete Cache" function).

That will output into kodi.log a report whenever you open any plugin directory. Note that it will add overhead to do the logging so remember to turn it off when you're done!

It will output something like the following in the log:

INFO <general>: [plugin.video.themoviedb.helper]
   DIRECTORY TIMER REPORT
   info=trakt_userlist&list_name=Rotten%20Tomatoes%3a%20Best%20of%202018&list_slug=rotten-tomatoes-best-of-2018&plugin_category=Rotten%20Tomatoes%3a%20Best%20of%202018&user_slug=lish408
   get_list       :   1.242 sec
    - kodi_db     :   0.714 sec
   add_items      :   3.749 sec
    - item_tmdb   :   0.708 sec (Average) |  15
    - item_ftv    :   1.805 sec (Average) |  19
    - item_kodi   :   None
    - item_trakt  :   0.393 sec (Average) |   1
    - item_build  :   0.023 sec (Average) |  20
   total          :   4.990 sec
   ------------------------------

   item_tmdb:
   0.062  0.625  0.596  0.681  0.677  0.712  0.672  0.736  0.748  0.755  0.767  0.775  0.851  0.890  1.080 

   item_ftv:
   0.142  0.145  0.089  0.381  1.026  1.394  1.263  2.322  2.346  2.143  2.438  2.437  2.663  2.570  2.600  2.292  2.586  2.760  2.700 

That output is on a Trakt list I've never opened with every setting enabled, so overall about the slowest type of scenario possible (other than first sync of inprogress tv which is particularly slow).

Understanding the Output

get_items Time it takes to get the base list from the API, do some basic configuration, and also grab Kodi's library. You can see from the kodi_db line that I could save 0.714 of that 1.242 by disabling the Kodi library lookup setting.

Retrieving my library is slow here because I'm using my large dummy test library with 1000+ movies in it. My real library of approx 250 movies is much faster (around 0.300s max)

add_items Time it takes to retrieve all the extra TMDb, FanartTV, Trakt, and Kodi details for all the items. This is the total time of all the requests. Each part of the request is itemised underneath.

You can see that the most expensive is FanartTV. The value is the average time of all threads which should give a fairly decent picture of what the typical cost is. The individual thread timings are provided below the table in a list

total That's how long the entire process took from requesting the plugin directory to displaying the items on screen.

Bequiet19 commented 2 years ago

@jurialmunkey These are my average results. I took a list I didn’t open to have realistic results.The latest version of tmdb helper. There is little improvement. The biggest delay is with main movie fanart image. When I switch to the next movie everything appears almost instant (clearlogo, ratings, studio logo, all metadata... ) except the fanart movie image which is about 3 seconds late. This is from an android device.

DIRECTORY TIMER REPORT
                                                   info=trakt_userlist&list_name=Rotten%20Tomatoes%3a%20Best%20of%202018&list_slug=rotten-tomatoes-best-of-2018&plugin_category=Rotten%20Tomatoes%3a%20Best%20of%202018&user_slug=lish408
                                                   ------------------------------
                                                   get_list       :   1.099 sec
                                                    - kodi_db     :   None
                                                   add_items      :   8.453 sec
                                                    - item_tmdb   :   1.859 sec avg |   2.704 sec max |  21
                                                    - item_ftv    :   3.788 sec avg |   5.444 sec max |  20
                                                    - item_kodi   :   None
                                                    - item_trakt  :   None
                                                    - item_build  :   0.058 sec avg |   1.219 sec all |  21
                                                   ------------------------------
                                                   Total          :   9.552 sec

                                                   item_tmdb:
                                                   0.243  0.051  1.288  1.789  1.915  1.915  1.996  2.048  2.094  2.100  1.619  1.943  1.977  1.974  1.759  2.449  2.494  2.059  2.262  2.357  2.704 

                                                   item_ftv:
                                                   0.182  2.772  3.060  2.548  2.535  3.317  3.128  2.941  3.802  3.960  4.491  4.012  4.517  5.444  4.905  5.136  4.970  4.672  4.853  4.509
jurialmunkey commented 2 years ago

When I switch to the next movie everything appears almost instant (clearlogo, ratings, studio logo, all metadata... ) except the fanart movie image which is about 3 seconds late

How long images take to load has nothing to do with Tmdbhelper. Once the items appear on screen, tmdbhelper is finished. Tmdbhelper just provides the image url to kodi, it doesn't download the image itself. It is kodi which downloads the image and displays it on screen.

Tmdbhelper provides ALL the metadata for the items at the same time. If there is a delay with images displaying on screen but the items are there then that's to do with kodi, your internet connection, and/or the website the image is from. If this is your main issue then it's not tmdbhelper which is slow.

Bequiet19 commented 2 years ago

@jurialmunkey I understand, but this kind of thing has never happened before. I compared this with version 4.4.0 from kodi repo. In version 4.4.0 list opening is slower but when I switch from movie to movie there is not deley. Opening the list itself is faster in last version, but when it enters the list, the appearance of the fanart image is delayed, for what reason I don't know. Also when I switch from one movie to another the same thing happens. Again I say the opening of the list has improved but something has happened with this. If I need to, I can record a video to see what it's all about.

jurialmunkey commented 2 years ago

@jurialmunkey I understand, but this kind of thing has never happened before. I compared this with version 4.4.0 from kodi repo. In version 4.4.0 list opening is slower but when I switch from movie to movie there is not deley. Opening the list itself is faster in last version, but when it enters the list, the appearance of the fanart image is delayed, for what reason I don't know. Also when I switch from one movie to another the same thing happens. Again I say the opening of the list has improved but something has happened with this. If I need to, I can record a video to see what it's all about.

A video would be helpful.

Are you sure that these fanart images that are taking longer to load are simply not new images whereas the previous version was an already cached image? Once Kodi has downloaded an image it adds it to the texture cache - so an old image will show as soon as the url is there; but for a new image there will always be a delay because it needs to be downloaded first - you'll see this even in the library when you add a new item.

The only reason I can think of for a delay in image loading caused by TMDbHelper would be if the skin is getting the fanart from the service monitor rather than the item itself, which is a really odd approach and I don't know why a skin would do that. And anyway, it drops all the artwork properties at the same time, so the fanart url should be available at roughly the same time as the clearart etc.

Bequiet19 commented 2 years ago

@jurialmunkey To get realistic results I deleted all thumnails and all caches. The first is tmdb helper version 4.4.0. As you can see, all the images are displayed at the same time without delay. https://files.fm/f/87kzg9t2g The second is the latest version of tmdb helper. As you can see there is a delay when switching movies. https://files.fm/f/r4c6tgdnw Both lists are the same. Tested under the same conditions. Sorry for the bad videos and the way I pinned the files but github doesn't support large files.

jurialmunkey commented 2 years ago

@Bequiet19

Did you delete Textures13.db from userdata? That's the one that counts.

Also, what skin is that? I'd like to look at the code. It looks like it is getting fanart from the service monitor which is a really odd approach. Still, I just can't see any reason why any changes since 4.4.0 would result in the artwork properties suddenly being filled slower than ratings (but that looks like what is happening) - I almost always get both threads finishing at the same time and if anything the ratings lag behind because that thread starts later and has more work to do.

Bequiet19 commented 2 years ago

@jurialmunkey Of course. During both tests I deleted Textures13.db. This is titan bingie mode 2.0.3. https://github.com/AchillesPunks/repository.titan.bingie.mod

Bequiet19 commented 2 years ago

@jurialmunkey It's not up to the skin. I just tried aeon nox the same thing happens. A poster appeared and then after two or three seconds a fanart image.

jurialmunkey commented 2 years ago

@jurialmunkey It's not up to the skin. I just tried aeon nox the same thing happens. A poster appeared and then after two or three seconds a fanart image.

If it's happening in Aeon Nox then it can't be TMDbHelper because Aeon Nox doesn't use the service monitor. It is impossible for a plugin to modify the properties of a listitem after it is created - so if the list of items is on screen then the artwork property is already there.

If you are seeing a delay in Aeon Nox then that's entirely to do with how long it is taking Kodi to download the image. Most likely what is happening is that in one version of TMDbHelper you have the image coming from TMDb and in the other you have it coming from FanartTV, and one is slower than the other (or higher resolution, larger file size etc.).

You can inspect the properties by creating an xml file like the following and dropping it in your skin's 1080i folder (or it might be 16x9 or xml depending on the skin - its the one where the rest of the skin xml files are). Custom_Overlay_1189.zip

This will show you at the top of the screen what the url for the fanart is.

<?xml version="1.0" encoding="UTF-8"?>
<window type="dialog" id="1189">
    <zorder>2</zorder>
    <visible>true</visible>
    <controls>
        <control type="label">
            <height>40</height>
            <textcolor>magenta</textcolor>
            <label>$INFO[ListItem.Art(fanart)]</label>
        </control>
    </controls>
</window>
jurialmunkey commented 2 years ago

@Bequiet19 - It'll be because a while back FanartTV changed how they handled "no language" items so that posters without text got the language "00" rather than "en". But for some reason they made a different (and undocumented) change for fanart where it went from default to "en" to now "" (instead of "00" like the change with posters).

No idea why the inconsistency but the side effect of me adding a language fix meant that fanart started coming solely from TMDb. TMDb recently started providing 4k fanart which is a much higher quality than most of the 1080p art on fanarttv, hence the longer download time.

Anyway, 4.5.14 will force fanart from fanarttv if the option is enabled so that the behaviour is the same as it was in 4.4.0 prior to the API change.

Bequiet19 commented 2 years ago

@jurialmunkey The situation is a little better. The same thing still happens with some movies. I don't know why this is happening. Maybe because they are, as you say, bigger pictures, I don't know.

matke-84 commented 2 years ago

@jurialmunkey Jurial my friend, you did a very good job with this update. You remember that about a year ago we talked about this that you need to speed up tmdb helper on android. Now we are very close to tmdb helper being the ideal addon for android. Maybe if we could get two or three seconds more at speed it would be perfect. In any case, go ahead. Keep developing this great addon. All the best my friend. 😉

matke-84 commented 2 years ago

@jurialmunkey Hmmmm. There is indeed some delay with the fanart. Now I looked at the size of the downloaded fanart files. All are in full hd resolution and the size is at most about 500kb. So I'm not sure it's up to file size. Again, on the other hand, it is not clear to me since it downloads everything from fanart.tv, why it downloads one image quickly and needs more time for another. Really very strange situation. 🤔

drinfernoo commented 2 years ago

Fanary.tv is notorious for being rather slow to respond to requests, as well.

matke-84 commented 2 years ago

@drinfernoo I agree. But as far as I saw in the video posted by @Bequiet19 I see that with the old version it was not a problem. That's what's interesting.

jurialmunkey commented 2 years ago

@jurialmunkey Hmmmm. There is indeed some delay with the fanart. Now I looked at the size of the downloaded fanart files. All are in full hd resolution and the size is at most about 500kb. So I'm not sure it's up to file size.

That's incorrect. If you look in the videos you can clearly see the Artwork for Avengers End Game is different in each so not a fair comparison at all. Also files in Thumbnails folder are similar sizes because Kodi texture cache has downsampled them.

In the "slow" video the artwork is coming from TMDb: https://www.themoviedb.org/t/p/original/7RyHsO4yDXtBv1zUU3mTpHeQ0d5.jpg That artwork is 1617kb and is 2160p. With default Kodi advancedsettings, Kodi's texture cache uses a bicubic filter to downsample fanart to 1080p and save it to disk before the skin background image loader can access it.

By comparison, in the "fast" video the artwork shown comes from FanartTV: https://images.fanart.tv/fanart/avengers-endgame-5c979f35948c7.jpg That artwork is only 996kb and is 1080p. As it is not downsampled, Kodi can load the image directly into the background image loader without waiting for the texture cache to save the downsampled image to disk first.

To make it a fair comparison you need to compare two images of similar size and resolution. Also, you can't have first traversed over a higher resolution image as that will add a bottleneck in Kodi's image processing queue.

matke-84 commented 2 years ago

@jurialmunkey Ohhhh yes. Now I see that the pictures are different. But wait. Now I'm checking my settings. I set up to have my pictures pulled from fanart.tv. I also inserted my api key. Why then pull fanart image from the tmdb site which is bigger. That may be the problem then. EDIT: I'm sorry I didn't download the latest version. Looks like you sorted it out so they pulls fanart pictures from fanart.tv as well.

Bequiet19 commented 2 years ago

@jurialmunkey It is much better with the new update, there is not too much delay. We are getting closer to the speed of a FEN. :-) I want to show you how fast FEN open lists on an android. This is really amazing. With deleted texture13.db and thumbnails, the list of close to 100 movies opens almost immediately. What has he done here to open so fast? Did you manage to see something specific in the code? https://files.fm/f/nywrsrj87

jurialmunkey commented 2 years ago

@jurialmunkey It is much better with the new update, there is not too much delay. We are getting closer to the speed of a FEN. :-) I want to show you how fast FEN open lists on an android. This is really amazing. With deleted texture13.db and thumbnails, the list of close to 100 movies opens almost immediately. What has he done here to open so fast? Did you manage to see something specific in the code? https://files.fm/f/nywrsrj87

Kodi's texture cache has no relevance to how fast a plugin directory opens. You need to delete all Fen's caches for a fair comparison. It also has far fewer features than TMDbH and provides less metadata.

Bequiet19 commented 2 years ago

@jurialmunkey I think I found out where FEN got a little on fast. FEN has three scenarios for showing fanarts. The first two as tmdb helper. Without fanart.tv images, with all fanart.tv images and a third where it combines fanart.tv images (clearart, posters...) and tmdb images (mainly background fanart images). But there is another additional option. Choice of tmdb image resolution (low, medium, high and original). By default it is set to high. I guess there's some way to downsize an image and that's why it's displayed quickly. Because when I set it to the original image, the opening speed is reduced and there is a delay when switching from movie to movie. In any case, here is a video of the first opening of the FEN list, no cache, no thumbnails, everything is clean. This is an option where it combines fanart.tv and tmdb images with high resolution images (not original). https://files.fm/f/x6svewc8s Sorry please, I don't want to be boring and ungrateful. Progress is going in the right direction. The speed of tmdb helpers is much improved. I really love this addon and it has been an integral part of my computer for a long time but I would really like to use it on android as well. I just watch more and more movies on TV and tablet than on computer.

jurialmunkey commented 2 years ago

You need to define what you mean by slow because you're talking about two entirely separate things that have no bearing on each other - the speed an image loads is entirely separate from the speed the plugin directory loads.

I'll reiterate again - TMDbHelper does NOT download any images and the size of the image has no bearing on fast the plugin directory opens. A plugin directory only provides text metadata and image URLs to Kodi - e.g. just like a link to an image is a separate thing from the image it takes you to https://images.fanart.tv/fanart/avengers-endgame-5c979f35948c7.jpg -- linking to a larger image is NOT going to change how fast this comment loads.

Also I would hardly call that fast loading -- that directory in Fen took 11 seconds for it to open from when you clicked on it.

Bequiet19 commented 2 years ago

@jurialmunkey Well, I mean both. Open a list and switch from movie to movie. It is important to get a decent speed of both things to get the usability of using addon on android devices. I don't know how else to explain when the option is set in FEN to the original image and high resolution. When it is set on the original image then everything is slower. Maybe there is another explanation but I don't know how to explain it. Yes but this is the worst case scenario. FEN opens here a list of almost 100 movies here. A list of 20 movies opens in few seconds.

jurialmunkey commented 2 years ago

I don't know how else to explain when the option is set in FEN to the original image and high resolution.

The fanarttv api doesn't provide options for downscaled images. It is only possible to get downscaled images from TMDb.

The only downscaling option provided by fanarttv is preview which I doubt you want as it is a very small image: https://images.fanart.tv/preview/avengers-endgame-5c979f35948c7.jpg

By comparison TMDb provides multiple options (there are even lower than these but I think below 780x439 it is getting too small for fanart).

Quality Example Size
Original https://www.themoviedb.org/t/p/original/7RyHsO4yDXtBv1zUU3mTpHeQ0d5.jpg 1607kb
1280x720 https://www.themoviedb.org/t/p/w1280/7RyHsO4yDXtBv1zUU3mTpHeQ0d5.jpg 202kb
780x439 https://www.themoviedb.org/t/p/w780/7RyHsO4yDXtBv1zUU3mTpHeQ0d5.jpg 84kb

I can add an option to enable switching to 720p images but it will mean your artwork comes from TMDb not FanartTV.

Bequiet19 commented 2 years ago

@jurialmunkey Yes, I mentioned that this is an option for tmdb images, not for fanart.tv. Well you are right, I use fanart.tv images in tmdb helper. But if I understood tmdb helper well, where there are no images on fanart.tv, they use as fallback images from the tmdb site. So that option that might help a little. Also you can add the option to combine fanart.tv and tmdb images. But only as an option, since I like to use all the images from fanart.tv on my computer. They are much better and often the pictures from tmdb site have text on them, so they look like posters and I don't like that. But as an alternative for android it would be ok.

jurialmunkey commented 2 years ago

They are much better and often the pictures from tmdb site have text on them, so they look like posters and I don't like that.

This is fixable. I can filter these out because TMDb provides data about the language. It's how I determine landscape art (backdrop with iso_639_1 value), so I can just do the reverse for fanart (backdrop without iso_639_1 value).

Also you can add the option to combine fanart.tv and tmdb images.

I don't see much point in an extra option. Linking the preference order to the quality option should suffice for all scenarios: e.g. FanartTV On + Original Quality = FanartTV first then TMDb as fallback FanartTV On + Lower Quality = TMDb first then FanartTV as fallback FanartTV Off = TMDb only.

Bequiet19 commented 2 years ago

@jurialmunkey This is not a bad idea. But I might put an option for tmdb globally to we had a choice in each scenario for original and lower quality. But I don't know how big job this is.

jurialmunkey commented 2 years ago

@jurialmunkey This is not a bad idea. But I might put an option for tmdb globally to we had a choice in each scenario for original and lower quality. But I don't know how big job this is.

I'm sorry, I don't understand what you mean here. What do you mean by "an option for tmdb globally".

This would already give you an option for quality. There is no point reducing TMDb fanart quality but choosing to have fanart come from fanarttv. Any movie or show that exists on either service will at minimum have fanart and poster so there will never be a fallback for those. The fallbacks only matter for less common artwork types like clearlogo and landscape

Bequiet19 commented 2 years ago

@jurialmunkey Maybe I didn't understand you. Will there be an option to choose what quality the tmdb image (not fanart.tv) will be. For example, I chose a lower quality tmdb fanart image option and such images will be displayed to me. Did I understand correctly.

jurialmunkey commented 2 years ago

@jurialmunkey Maybe I didn't understand you. Will there be an option to choose what quality the tmdb image (not fanart.tv) will be. For example, I chose a lower quality tmdb fanart image option and such images will be displayed to me. Did I understand correctly.

It is not possible to choose quality for fanarttv. It is only possible to choose quality for TMDb.

jurialmunkey commented 2 years ago

^^ v4.5.26 adds an artwork quality option for TMDb under General settings.

Original Uses highest quality available. Prefers fanarttv artwork (if enabled and available)

High Uses 1280x720 fanart from TMDb Prefers fanarttv for all other artwork types (if enabled and available)

Low Uses 780x439 fanart and 342x502 posters from TMDb Prefers fanarttv for all other artwork types (if enabled and available)

Bequiet19 commented 2 years ago

@jurialmunkey Woooow. That's it. Now it opens really nicely. :-) Just tell me does tmdb helper use episodes thumnails from fanart.tv or tmdb site? If they use it from the tmdb site, can we include them in this option or maybe it's already included.

Bequiet19 commented 2 years ago

@jurialmunkey I'm playing with the new setting a bit now. With a low setting, loading and switching from movie to movie is really fast. With high settings are also good performance. Now the only thing missing is that, if possible at all, we can get litle faster entering in the list. The average entry time is now 7 seconds. If we could get down to 5 seconds it would be perfect. And if that’s not possible, this is a very good improvement over before. Thank you sir for trying to improve this fantastic addon. You're a really good man.

jurialmunkey commented 2 years ago

@jurialmunkey Woooow. That's it. Now it opens really nicely. :-) Just tell me does tmdb helper use episodes thumnails from fanart.tv or tmdb site? If they use it from the tmdb site, can we include them in this option or maybe it's already included.

They come from TMDb (fanarttv doesn't have thumbs). Your comment made me realise I missed those though! Should be fixed now.

Bequiet19 commented 2 years ago

@jurialmunkey Thanks. Loading episodes is faster as well as switching between episodes. What do you think, does entering in lists can be accelerated just a little more? Also entry from the tv show into the episodes also opens litle slowly. If that could be accelerated a bit, it would be great.

matke-84 commented 2 years ago

@jurialmunkey

This is fixable. I can filter these out because TMDb provides data about the language. It's how I determine landscape art (backdrop with iso_639_1 value), so I can just do the reverse for fanart (backdrop without iso_639_1 value).

This is a good idea for a fanart from TMDb. Some of them have a bunch of captions. For fanart it doesn't matter language.

xyzfre commented 2 years ago

Great work on this new update I use a Nvidia shield on android 11 which sucks lol but I do see a difference on fanart images thank you for all the hard work that goes into TMDb Helper truly is an amazing project

xyzfre commented 2 years ago

I use AuraMod and I just noticed a few shows that were on my next episodes we're missing episode thumbs I never made an issue about it because a couple were very old shows or those weird ones that nobody watches lol and now they all show up properly GREAT JOB👍🏼

matke-84 commented 2 years ago

@jurialmunkey I noticed that some of the original logos are very large. Because of that some movie logos open with delay. What do you think we should do a similar thing with logo like with posters and fanart, except that I would only go with size W500. Everything below that is little for skins. EDIT: Actually can also w300 for Low setting. It doesn't look so bad.

jurialmunkey commented 2 years ago

@jurialmunkey I noticed that some of the original logos are very large. Because of that some movie logos open with delay. What do you think we should do a similar thing with logo like with posters and fanart, except that I would only go with size W500. Everything below that is little for skins. EDIT: Actually can also w300 for Low setting. It doesn't look so bad.

Definitely, was thinking something similar as I was noticing the resolution on some of the logos from TMDb is massive - way bigger than necessary.

Added. I set it to w500 for high/medium and w300 for low. I was going to reduce it on original too but changed my mind. Ideally there would be a w800 setting to bring it in line with fanarttv (ftv has 800 and 400 for clearlogos) - but original will have to do.