jurialmunkey / plugin.video.themoviedb.helper

GNU General Public License v3.0
200 stars 94 forks source link

player issue #652

Closed mrXoo closed 2 years ago

mrXoo commented 2 years ago

Hi there, Ive a strange issue going on with when I try to play something using oath player. What happens is my players come up as normal and I select oath and then the searching for sources box flashes up then disappears then I get the busy wheel for ever. I can click back and it will disappear. This only happens on the 1 player and the strange thing is it works perfectly fine on my windows install. Im using CoreELEC matrix. It also works fine on leia CE version. Also If I go to the addon directly it works just fine.

Attached is log and player.

https://www.dropbox.com/s/bpo8z5qsxc0sc5b/kodi.log?dl=1 https://www.dropbox.com/s/ljyyp5hd1t2ddv5/direct.theoath.json?dl=0

jurialmunkey commented 2 years ago

Your keys are not url percent encoded yet the plugin clearly expects percent encoding (you can tell by all % in the path) https://github.com/jurialmunkey/plugin.video.themoviedb.helper/wiki/Player-Function#special-suffixes

To URL percent encode you change for example {plot} to {plot_url}. Some plugins might need _url+ or double percent encoding, but plain _url is the standard and what that encoding looks like.

You'll need to add _url to any keys which output special characters or have spaces. Any of the keys listed here can have encoding applied - https://github.com/jurialmunkey/plugin.video.themoviedb.helper/blob/matrix/resources/lib/addon/constants.py#L53-L55

mrXoo commented 2 years ago

So the player needs changing?

Any idea why it would work fine on windows but not CE?

jurialmunkey commented 2 years ago

So the player needs changing?

Yes, the player needs to be changed because whoever made it did not include encoding for the keys in the plugin URI despite the plugin clearly expecting it

Any idea why it would work fine on windows but not CE?

Are you playing the same item? Most of the time you can get away with plain text keys. It is only if the info contains a reserved character that you'll run into problems. Just like how you can't call a file .:/?* because those characters have a special purpose in the filesystem, URIs also reserve some special characters.

For instance, see the output of your player in your log. Notice how the plot looks different to everything else? That's because it isn't percent encoded. In particular, notice the word mankind's? Quote marks are reserved characters so that'll break things.

plugin://plugin.video.theoath/?action=play&title=Eternals&year=2021&imdb=tt9032400&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22tt9032400%22%2C+%22tmdb%22%3A+%22524434%22%2C+%22imdb%22%3A+%22tt9032400%22%2C+%22year%22%3A+%222021%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22The Eternals are a team of ancient aliens who have been living on Earth in secret for thousands of years. When an unexpected tragedy forces them out of the shadows they are forced to reunite against mankind’s most ancient enemy the Deviants.%22%2C+%22votes%22%3A+%22%22%2C+%22title%22%3A+%22Eternals%22%2C+%22fanart%22%3A+%22None%22%2C+%22tagline%22%3A+%22%22%2C+%22writer%22%3A+%22%22%2C+%22next%22%3A+%22%22%2C+%22poster%22%3A+%22None%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22director%22%3A+%22%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22metacache%22%3A+true%2C+%22premiered%22%3A+%222021-11-03%22%2C+%22originaltitle%22%3A+%22Eternals%22%2C+%22cast%22%3A+%5B%5B%22%22%5D%5D%2C+%22mpaa%22%3A+%22%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dtrailer%26name%3DEternals%2B%25282021%2529%22%7D&t=20220219095525341201

mrXoo commented 2 years ago

Thanks so much for the explanation im still having issues getting it to play. Im trying to work through it. below is the original path from the oath addon. plugin://plugin.video.theoath/?action=play&title=Eternals&year=2021&imdb=tt9032400&meta=%7B%22title%22%3A+%22Eternals%22%2C+%22originaltitle%22%3A+%22Eternals%22%2C+%22year%22%3A+%222021%22%2C+%22genre%22%3A+%22Action+%2F+Adventure+%2F+Fantasy+%2F+Science+Fiction%22%2C+%22duration%22%3A+%229360%22%2C+%22rating%22%3A+%226.4%22%2C+%22votes%22%3A+%22257%2C050%22%2C+%22mpaa%22%3A+%22PG-13%22%2C+%22director%22%3A+%22Chlo%5Cu00e9+Zhao%22%2C+%22plot%22%3A+%22The+Eternals+are+a+team+of+ancient+aliens+who+have+been+living+on+Earth+in+secret+for+thousands+of+years.+When+an+unexpected+tragedy+forces+them+out+of+the+shadows%2C+they+are+forced+to+reunite+against+mankind%5Cu2019s+most+ancient+enemy%2C+the+Deviants.%22%2C+%22tagline%22%3A+%22In+the+beginning...%22%2C+%22imdb%22%3A+%22tt9032400%22%2C+%22tmdb%22%3A+%22524434%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw500%2FbcCBq9N1EMo3daNIjWJ8kYvrQm6.jpg%22%2C+%22next%22%3A+%22https%3A%2F%2Fwww.imdb.com%2Fsearch%2Ftitle%3Ftitle_type%3Dmovie%2Ctv_movie%26release_date%3D2021-02-20%2C2021-12-22%26production_status%3Dreleased%26count%3D20%26start%3D21%26ref_%3Dadv_nxt%22%2C+%22metacache%22%3A+true%2C+%22label%22%3A+%22Eternals%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw1280%2Fc6H7Z4u73ir3cIoCteuhJh7UCAR.jpg%22%2C+%22premiered%22%3A+%222021-11-03%22%2C+%22writer%22%3A+%22Patrick+Burleigh%2C+Ryan+Firpo%2C+Chlo%5Cu00e9+Zhao%2C+Matthew+K.+Firpo%22%2C+%22castwiththumb%22%3A+%5B%7B%22name%22%3A+%22Gemma+Chan%22%2C+%22role%22%3A+%22Sersi%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FstTKj4iNauhqlVmZ6XAsFsvcMCY.jpg%22%7D%2C+%7B%22name%22%3A+%22Richard+Madden%22%2C+%22role%22%3A+%22Ikaris%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FzP1QxxjhtnnjMutuYKtlOnvYD7P.jpg%22%7D%2C+%7B%22name%22%3A+%22Angelina+Jolie%22%2C+%22role%22%3A+%22Thena%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F9kkfIiufGORw4bELN79DuTaKqAy.jpg%22%7D%2C+%7B%22name%22%3A+%22Kumail+Nanjiani%22%2C+%22role%22%3A+%22Kingo%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F9EyrK1Cv7ey1h1GgmsVAOn45w6G.jpg%22%7D%2C+%7B%22name%22%3A+%22Barry+Keoghan%22%2C+%22role%22%3A+%22Druig%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F15xPjrzSbtXlbQUhmLpQUil4tCN.jpg%22%7D%2C+%7B%22name%22%3A+%22Lauren+Ridloff%22%2C+%22role%22%3A+%22Makkari%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Ff9ArdlIffHBeG7vLtuqna1KXvfk.jpg%22%7D%2C+%7B%22name%22%3A+%22Lia+McHugh%22%2C+%22role%22%3A+%22Sprite%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FKls4aDLM7ASPCJfn0lmMKlU9Xy.jpg%22%7D%2C+%7B%22name%22%3A+%22Brian+Tyree+Henry%22%2C+%22role%22%3A+%22Phastos%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F8JtMLXctGCG9axXTaQXtQktiHMN.jpg%22%7D%2C+%7B%22name%22%3A+%22Ma+Dong-seok%22%2C+%22role%22%3A+%22Gilgamesh%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fzt1vx7FesNA4x6mTZtyzu2uco8E.jpg%22%7D%2C+%7B%22name%22%3A+%22Salma+Hayek%22%2C+%22role%22%3A+%22Ajak%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F3j8MpAjyopkAc8mbNiDeXyqBmcS.jpg%22%7D%2C+%7B%22name%22%3A+%22Kit+Harington%22%2C+%22role%22%3A+%22Dane+Whitman%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FnoInYh5IKASiecR5lHJSjXIDmkm.jpg%22%7D%2C+%7B%22name%22%3A+%22Harish+Patel%22%2C+%22role%22%3A+%22Karun%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fg2aHA5J5ODMcBgIwCa72ykcmN85.jpg%22%7D%2C+%7B%22name%22%3A+%22David+Kaye%22%2C+%22role%22%3A+%22Arishem+%28voice%29%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FizxtFSio5twcVA1oJWPvobxpcZj.jpg%22%7D%2C+%7B%22name%22%3A+%22Bill+Skarsg%5Cu00e5rd%22%2C+%22role%22%3A+%22Kro+%28voice%29%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F6OCBeTRLXrNKqvSz4HIweUWSIn6.jpg%22%7D%2C+%7B%22name%22%3A+%22Haaz+Sleiman%22%2C+%22role%22%3A+%22Ben%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FvhNbQ8BTP6wK2jArwv2bwbuN31t.jpg%22%7D%2C+%7B%22name%22%3A+%22Esai+Daniel+Cross%22%2C+%22role%22%3A+%22Jack%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Alan+Scott%22%2C+%22role%22%3A+%22Patrick%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FslzT9A20qq8K4WbmAqiYOQUp0mZ.jpg%22%7D%2C+%7B%22name%22%3A+%22Hannah+Dodd%22%2C+%22role%22%3A+%22Sandra%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F55KfjaxQJClbl6pEcPMKHDle4Jj.jpg%22%7D%2C+%7B%22name%22%3A+%22Adria+Escudero%22%2C+%22role%22%3A+%22Diego%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FpK9p7twhqYw9fJFxXgAuZUyJ2Pc.jpg%22%7D%2C+%7B%22name%22%3A+%22Sebasti%5Cu00e1n+Viveros%22%2C+%22role%22%3A+%22Jano%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FszDZssPtpGwcWS2WsSIDvCNngnO.jpg%22%7D%2C+%7B%22name%22%3A+%22Nikkita+Chadha%22%2C+%22role%22%3A+%22Bollywood+Star%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fj0d1shh4OEBVjuZlFAoC1pugaps.jpg%22%7D%2C+%7B%22name%22%3A+%22Grahame+Fox%22%2C+%22role%22%3A+%22Kro+On-Set+Reader%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FsGn6CPIpnVA9HKd6TvDbBM5ja5r.jpg%22%7D%2C+%7B%22name%22%3A+%22Zain+Al+Rafeea%22%2C+%22role%22%3A+%22Mesopotamian+Young+Man%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fb9ZlPHX1KNjy1FeQ1SBAl3lvd8E.jpg%22%7D%2C+%7B%22name%22%3A+%22Alberto+Rodr%5Cu00edguez%22%2C+%22role%22%3A+%22Mesopotamian+Father%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Lucia+Efstathiou%22%2C+%22role%22%3A+%22Natural+History+Museum+Student%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F8T4j7NyO0uqiQrF3k0FhVqaiXzj.jpg%22%7D%2C+%7B%22name%22%3A+%22Derek+Horsham%22%2C+%22role%22%3A+%22Ancient+Babylon+Smuggler+%231%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FhYYfhgMV7R1yqQunIlSMaM3sUij.jpg%22%7D%2C+%7B%22name%22%3A+%22Jeff+Mirza%22%2C+%22role%22%3A+%22Gupta+Hindu+Priest%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FxgRKoMFBQGavRT65OBMxcABVe1G.jpg%22%7D%2C+%7B%22name%22%3A+%22Ascension+Martinez+Rubio%22%2C+%22role%22%3A+%22Mesopotamian+Grandmother%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Ozer+Ercan%22%2C+%22role%22%3A+%22Ancient+Babylon+Smuggler+%232%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FeaECBN3bheGnHysvc2PiizIOUjp.jpg%22%7D%2C+%7B%22name%22%3A+%22Ariadna+Vadillo+Soto%22%2C+%22role%22%3A+%22Ancient+Babylon+Farmer%22%2C+%22thumbnail%22%3A+%22%22%7D%5D%2C+%22status%22%3A+%22Released%22%2C+%22studio%22%3A+%22Marvel+Studios%22%2C+%22country%22%3A+%22United+States+of+America%22%2C+%22imdbnumber%22%3A+%22tt9032400%22%2C+%22code%22%3A+%22524434%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dimdb_trailer%26name%3DEternals%26tmdb%3D524434%26imdb%3Dtt9032400%22%7D&t=20220220163905643877','resume:false') and this is the same url decoded plugin://plugin.video.theoath/?action=play&title=Eternals&year=2021&imdb=tt9032400&meta={"title":+"Eternals",+"originaltitle":+"Eternals",+"year":+"2021",+"genre":+"Action+/+Adventure+/+Fantasy+/+Science+Fiction",+"duration":+"9360",+"rating":+"6.4",+"votes":+"257,050",+"mpaa":+"PG-13",+"director":+"Chlo\u00e9+Zhao",+"plot":+"The+Eternals+are+a+team+of+ancient+aliens+who+have+been+living+on+Earth+in+secret+for+thousands+of+years.+When+an+unexpected+tragedy+forces+them+out+of+the+shadows,+they+are+forced+to+reunite+against+mankind\u2019s+most+ancient+enemy,+the+Deviants.",+"tagline":+"In+the+beginning...",+"imdb":+"tt9032400",+"tmdb":+"524434",+"poster":+"https://image.tmdb.org/t/p/w500/bcCBq9N1EMo3daNIjWJ8kYvrQm6.jpg",+"next":+"https://www.imdb.com/search/title?title_type=movie,tv_movie&release_date=2021-02-20,2021-12-22&production_status=released&count=20&start=21&ref_=adv_nxt",+"metacache":+true,+"label":+"Eternals",+"fanart":+"https://image.tmdb.org/t/p/w1280/c6H7Z4u73ir3cIoCteuhJh7UCAR.jpg",+"premiered":+"2021-11-03",+"writer":+"Patrick+Burleigh,+Ryan+Firpo,+Chlo\u00e9+Zhao,+Matthew+K.+Firpo",+"castwiththumb":+[{"name":+"Gemma+Chan",+"role":+"Sersi",+"thumbnail":+"https://image.tmdb.org/t/p/w185/stTKj4iNauhqlVmZ6XAsFsvcMCY.jpg"},+{"name":+"Richard+Madden",+"role":+"Ikaris",+"thumbnail":+"https://image.tmdb.org/t/p/w185/zP1QxxjhtnnjMutuYKtlOnvYD7P.jpg"},+{"name":+"Angelina+Jolie",+"role":+"Thena",+"thumbnail":+"https://image.tmdb.org/t/p/w185/9kkfIiufGORw4bELN79DuTaKqAy.jpg"},+{"name":+"Kumail+Nanjiani",+"role":+"Kingo",+"thumbnail":+"https://image.tmdb.org/t/p/w185/9EyrK1Cv7ey1h1GgmsVAOn45w6G.jpg"},+{"name":+"Barry+Keoghan",+"role":+"Druig",+"thumbnail":+"https://image.tmdb.org/t/p/w185/15xPjrzSbtXlbQUhmLpQUil4tCN.jpg"},+{"name":+"Lauren+Ridloff",+"role":+"Makkari",+"thumbnail":+"https://image.tmdb.org/t/p/w185/f9ArdlIffHBeG7vLtuqna1KXvfk.jpg"},+{"name":+"Lia+McHugh",+"role":+"Sprite",+"thumbnail":+"https://image.tmdb.org/t/p/w185/Kls4aDLM7ASPCJfn0lmMKlU9Xy.jpg"},+{"name":+"Brian+Tyree+Henry",+"role":+"Phastos",+"thumbnail":+"https://image.tmdb.org/t/p/w185/8JtMLXctGCG9axXTaQXtQktiHMN.jpg"},+{"name":+"Ma+Dong-seok",+"role":+"Gilgamesh",+"thumbnail":+"https://image.tmdb.org/t/p/w185/zt1vx7FesNA4x6mTZtyzu2uco8E.jpg"},+{"name":+"Salma+Hayek",+"role":+"Ajak",+"thumbnail":+"https://image.tmdb.org/t/p/w185/3j8MpAjyopkAc8mbNiDeXyqBmcS.jpg"},+{"name":+"Kit+Harington",+"role":+"Dane+Whitman",+"thumbnail":+"https://image.tmdb.org/t/p/w185/noInYh5IKASiecR5lHJSjXIDmkm.jpg"},+{"name":+"Harish+Patel",+"role":+"Karun",+"thumbnail":+"https://image.tmdb.org/t/p/w185/g2aHA5J5ODMcBgIwCa72ykcmN85.jpg"},+{"name":+"David+Kaye",+"role":+"Arishem+(voice)",+"thumbnail":+"https://image.tmdb.org/t/p/w185/izxtFSio5twcVA1oJWPvobxpcZj.jpg"},+{"name":+"Bill+Skarsg\u00e5rd",+"role":+"Kro+(voice)",+"thumbnail":+"https://image.tmdb.org/t/p/w185/6OCBeTRLXrNKqvSz4HIweUWSIn6.jpg"},+{"name":+"Haaz+Sleiman",+"role":+"Ben",+"thumbnail":+"https://image.tmdb.org/t/p/w185/vhNbQ8BTP6wK2jArwv2bwbuN31t.jpg"},+{"name":+"Esai+Daniel+Cross",+"role":+"Jack",+"thumbnail":+""},+{"name":+"Alan+Scott",+"role":+"Patrick",+"thumbnail":+"https://image.tmdb.org/t/p/w185/slzT9A20qq8K4WbmAqiYOQUp0mZ.jpg"},+{"name":+"Hannah+Dodd",+"role":+"Sandra",+"thumbnail":+"https://image.tmdb.org/t/p/w185/55KfjaxQJClbl6pEcPMKHDle4Jj.jpg"},+{"name":+"Adria+Escudero",+"role":+"Diego",+"thumbnail":+"https://image.tmdb.org/t/p/w185/pK9p7twhqYw9fJFxXgAuZUyJ2Pc.jpg"},+{"name":+"Sebasti\u00e1n+Viveros",+"role":+"Jano",+"thumbnail":+"https://image.tmdb.org/t/p/w185/szDZssPtpGwcWS2WsSIDvCNngnO.jpg"},+{"name":+"Nikkita+Chadha",+"role":+"Bollywood+Star",+"thumbnail":+"https://image.tmdb.org/t/p/w185/j0d1shh4OEBVjuZlFAoC1pugaps.jpg"},+{"name":+"Grahame+Fox",+"role":+"Kro+On-Set+Reader",+"thumbnail":+"https://image.tmdb.org/t/p/w185/sGn6CPIpnVA9HKd6TvDbBM5ja5r.jpg"},+{"name":+"Zain+Al+Rafeea",+"role":+"Mesopotamian+Young+Man",+"thumbnail":+"https://image.tmdb.org/t/p/w185/b9ZlPHX1KNjy1FeQ1SBAl3lvd8E.jpg"},+{"name":+"Alberto+Rodr\u00edguez",+"role":+"Mesopotamian+Father",+"thumbnail":+""},+{"name":+"Lucia+Efstathiou",+"role":+"Natural+History+Museum+Student",+"thumbnail":+"https://image.tmdb.org/t/p/w185/8T4j7NyO0uqiQrF3k0FhVqaiXzj.jpg"},+{"name":+"Derek+Horsham",+"role":+"Ancient+Babylon+Smuggler+#1",+"thumbnail":+"https://image.tmdb.org/t/p/w185/hYYfhgMV7R1yqQunIlSMaM3sUij.jpg"},+{"name":+"Jeff+Mirza",+"role":+"Gupta+Hindu+Priest",+"thumbnail":+"https://image.tmdb.org/t/p/w185/xgRKoMFBQGavRT65OBMxcABVe1G.jpg"},+{"name":+"Ascension+Martinez+Rubio",+"role":+"Mesopotamian+Grandmother",+"thumbnail":+""},+{"name":+"Ozer+Ercan",+"role":+"Ancient+Babylon+Smuggler+#2",+"thumbnail":+"https://image.tmdb.org/t/p/w185/eaECBN3bheGnHysvc2PiizIOUjp.jpg"},+{"name":+"Ariadna+Vadillo+Soto",+"role":+"Ancient+Babylon+Farmer",+"thumbnail":+""}],+"status":+"Released",+"studio":+"Marvel+Studios",+"country":+"United+States+of+America",+"imdbnumber":+"tt9032400",+"code":+"524434",+"mediatype":+"movie",+"trailer":+"plugin://plugin.video.theoath/?action=imdb_trailer&name=Eternals&tmdb=524434&imdb=tt9032400"}&t=20220220163905643877','resume:false') now im trying to adjust the player to include this information. does it need to be all in the same order?

drinfernoo commented 2 years ago

@jurialmunkey

Yes, the player needs to be changed because whoever made it did not include encoding for the keys in the plugin URI despite the plugin clearly expecting it

Alternatively, the add-on developer changed their path structure after there had been a player available.

mrXoo commented 2 years ago

been working on it for a couple of hours, now im really lost

mrXoo commented 2 years ago

If I put this link into the player the box flashes up then goes away. plugin://plugin.video.theoath/?action=play&title=Eternals&year=2021&imdb=tt9032400&meta=%7B%22title%22%3A+%22Eternals%22%2C+%22originaltitle%22%3A+%22Eternals%22%2C+%22year%22%3A+%222021%22%2C+%22genre%22%3A+%22Action+%2F+Adventure+%2F+Fantasy+%2F+Science+Fiction%22%2C+%22duration%22%3A+%229360%22%2C+%22rating%22%3A+%226.4%22%2C+%22votes%22%3A+%22257%2C050%22%2C+%22mpaa%22%3A+%22PG-13%22%2C+%22director%22%3A+%22Chlo%5Cu00e9+Zhao%22%2C+%22plot%22%3A+%22The+Eternals+are+a+team+of+ancient+aliens+who+have+been+living+on+Earth+in+secret+for+thousands+of+years.+When+an+unexpected+tragedy+forces+them+out+of+the+shadows%2C+they+are+forced+to+reunite+against+mankind%5Cu2019s+most+ancient+enemy%2C+the+Deviants.%22%2C+%22tagline%22%3A+%22In+the+beginning...%22%2C+%22imdb%22%3A+%22tt9032400%22%2C+%22tmdb%22%3A+%22524434%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw500%2FbcCBq9N1EMo3daNIjWJ8kYvrQm6.jpg%22%2C+%22next%22%3A+%22https%3A%2F%2Fwww.imdb.com%2Fsearch%2Ftitle%3Ftitle_type%3Dmovie%2Ctv_movie%26release_date%3D2021-02-20%2C2021-12-22%26production_status%3Dreleased%26count%3D20%26start%3D21%26ref_%3Dadv_nxt%22%2C+%22metacache%22%3A+true%2C+%22label%22%3A+%22Eternals%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw1280%2Fc6H7Z4u73ir3cIoCteuhJh7UCAR.jpg%22%2C+%22premiered%22%3A+%222021-11-03%22%2C+%22writer%22%3A+%22Patrick+Burleigh%2C+Ryan+Firpo%2C+Chlo%5Cu00e9+Zhao%2C+Matthew+K.+Firpo%22%2C+%22castwiththumb%22%3A+%5B%7B%22name%22%3A+%22Gemma+Chan%22%2C+%22role%22%3A+%22Sersi%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FstTKj4iNauhqlVmZ6XAsFsvcMCY.jpg%22%7D%2C+%7B%22name%22%3A+%22Richard+Madden%22%2C+%22role%22%3A+%22Ikaris%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FzP1QxxjhtnnjMutuYKtlOnvYD7P.jpg%22%7D%2C+%7B%22name%22%3A+%22Angelina+Jolie%22%2C+%22role%22%3A+%22Thena%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F9kkfIiufGORw4bELN79DuTaKqAy.jpg%22%7D%2C+%7B%22name%22%3A+%22Kumail+Nanjiani%22%2C+%22role%22%3A+%22Kingo%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F9EyrK1Cv7ey1h1GgmsVAOn45w6G.jpg%22%7D%2C+%7B%22name%22%3A+%22Barry+Keoghan%22%2C+%22role%22%3A+%22Druig%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F15xPjrzSbtXlbQUhmLpQUil4tCN.jpg%22%7D%2C+%7B%22name%22%3A+%22Lauren+Ridloff%22%2C+%22role%22%3A+%22Makkari%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Ff9ArdlIffHBeG7vLtuqna1KXvfk.jpg%22%7D%2C+%7B%22name%22%3A+%22Lia+McHugh%22%2C+%22role%22%3A+%22Sprite%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FKls4aDLM7ASPCJfn0lmMKlU9Xy.jpg%22%7D%2C+%7B%22name%22%3A+%22Brian+Tyree+Henry%22%2C+%22role%22%3A+%22Phastos%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F8JtMLXctGCG9axXTaQXtQktiHMN.jpg%22%7D%2C+%7B%22name%22%3A+%22Ma+Dong-seok%22%2C+%22role%22%3A+%22Gilgamesh%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fzt1vx7FesNA4x6mTZtyzu2uco8E.jpg%22%7D%2C+%7B%22name%22%3A+%22Salma+Hayek%22%2C+%22role%22%3A+%22Ajak%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F3j8MpAjyopkAc8mbNiDeXyqBmcS.jpg%22%7D%2C+%7B%22name%22%3A+%22Kit+Harington%22%2C+%22role%22%3A+%22Dane+Whitman%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FnoInYh5IKASiecR5lHJSjXIDmkm.jpg%22%7D%2C+%7B%22name%22%3A+%22Harish+Patel%22%2C+%22role%22%3A+%22Karun%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fg2aHA5J5ODMcBgIwCa72ykcmN85.jpg%22%7D%2C+%7B%22name%22%3A+%22David+Kaye%22%2C+%22role%22%3A+%22Arishem+%28voice%29%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FizxtFSio5twcVA1oJWPvobxpcZj.jpg%22%7D%2C+%7B%22name%22%3A+%22Bill+Skarsg%5Cu00e5rd%22%2C+%22role%22%3A+%22Kro+%28voice%29%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F6OCBeTRLXrNKqvSz4HIweUWSIn6.jpg%22%7D%2C+%7B%22name%22%3A+%22Haaz+Sleiman%22%2C+%22role%22%3A+%22Ben%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FvhNbQ8BTP6wK2jArwv2bwbuN31t.jpg%22%7D%2C+%7B%22name%22%3A+%22Esai+Daniel+Cross%22%2C+%22role%22%3A+%22Jack%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Alan+Scott%22%2C+%22role%22%3A+%22Patrick%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FslzT9A20qq8K4WbmAqiYOQUp0mZ.jpg%22%7D%2C+%7B%22name%22%3A+%22Hannah+Dodd%22%2C+%22role%22%3A+%22Sandra%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F55KfjaxQJClbl6pEcPMKHDle4Jj.jpg%22%7D%2C+%7B%22name%22%3A+%22Adria+Escudero%22%2C+%22role%22%3A+%22Diego%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FpK9p7twhqYw9fJFxXgAuZUyJ2Pc.jpg%22%7D%2C+%7B%22name%22%3A+%22Sebasti%5Cu00e1n+Viveros%22%2C+%22role%22%3A+%22Jano%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FszDZssPtpGwcWS2WsSIDvCNngnO.jpg%22%7D%2C+%7B%22name%22%3A+%22Nikkita+Chadha%22%2C+%22role%22%3A+%22Bollywood+Star%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fj0d1shh4OEBVjuZlFAoC1pugaps.jpg%22%7D%2C+%7B%22name%22%3A+%22Grahame+Fox%22%2C+%22role%22%3A+%22Kro+On-Set+Reader%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FsGn6CPIpnVA9HKd6TvDbBM5ja5r.jpg%22%7D%2C+%7B%22name%22%3A+%22Zain+Al+Rafeea%22%2C+%22role%22%3A+%22Mesopotamian+Young+Man%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2Fb9ZlPHX1KNjy1FeQ1SBAl3lvd8E.jpg%22%7D%2C+%7B%22name%22%3A+%22Alberto+Rodr%5Cu00edguez%22%2C+%22role%22%3A+%22Mesopotamian+Father%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Lucia+Efstathiou%22%2C+%22role%22%3A+%22Natural+History+Museum+Student%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2F8T4j7NyO0uqiQrF3k0FhVqaiXzj.jpg%22%7D%2C+%7B%22name%22%3A+%22Derek+Horsham%22%2C+%22role%22%3A+%22Ancient+Babylon+Smuggler+%231%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FhYYfhgMV7R1yqQunIlSMaM3sUij.jpg%22%7D%2C+%7B%22name%22%3A+%22Jeff+Mirza%22%2C+%22role%22%3A+%22Gupta+Hindu+Priest%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FxgRKoMFBQGavRT65OBMxcABVe1G.jpg%22%7D%2C+%7B%22name%22%3A+%22Ascension+Martinez+Rubio%22%2C+%22role%22%3A+%22Mesopotamian+Grandmother%22%2C+%22thumbnail%22%3A+%22%22%7D%2C+%7B%22name%22%3A+%22Ozer+Ercan%22%2C+%22role%22%3A+%22Ancient+Babylon+Smuggler+%232%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw185%2FeaECBN3bheGnHysvc2PiizIOUjp.jpg%22%7D%2C+%7B%22name%22%3A+%22Ariadna+Vadillo+Soto%22%2C+%22role%22%3A+%22Ancient+Babylon+Farmer%22%2C+%22thumbnail%22%3A+%22%22%7D%5D%2C+%22status%22%3A+%22Released%22%2C+%22studio%22%3A+%22Marvel+Studios%22%2C+%22country%22%3A+%22United+States+of+America%22%2C+%22imdbnumber%22%3A+%22tt9032400%22%2C+%22code%22%3A+%22524434%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dimdb_trailer%26name%3DEternals%26tmdb%3D524434%26imdb%3Dtt9032400%22%7D&t=20220220163905643877 I would have thought that would play it

jurialmunkey commented 2 years ago

@jurialmunkey

Yes, the player needs to be changed because whoever made it did not include encoding for the keys in the plugin URI despite the plugin clearly expecting it

Alternatively, the add-on developer changed their path structure after there had been a player available.

I guarantee it has always required encoding.

The rest of the url in the player file itself is percent encoded (except for those keys). It wouldn't make sense for only part of the paramstring to be encoded. If there's % in there then key will need _url or _encoded.

Also any plugin passing metadata in the url needs encoding due to special characters. It can still mostly work without encoding until you encounter a special character like a quote mark.

Most of the time the addon is only really relying on the ID to play and the rest is just metadata, so as long as it gets the ID and no special characters entirely break the string it will appear to work fine. I assume that's why I see so many player plugin uris misconfigured like this.

I didnt mean to sound rude and imply it was obvious by saying "clearly". Encoding is confusing as hell and it's a common mistake (which I think also stems from OpenMeta handling player keys differently). All I meant is that you can tell from the rest of the line what encoding is required because you can see the percent.

jurialmunkey commented 2 years ago

If I put this link into the player the box flashes up then goes away.

@mrXoo - My first guess is that the addon is probably not resolvable. Try changing your "is_resolvable": "true", line to false.

mrXoo commented 2 years ago

Bingo you've got it. Changed the is_resolveable to false and that link i posted for eternals works. Now I have to figure out the player

mrXoo commented 2 years ago

Okay so ive got movies working with this: "play_movie": "plugin://plugin.video.theoath/?action=play&title={title}&year={year}&imdb={imdb}&meta=%7B%22title%22%3A+%22{title}%22%2C+%22originaltitle%22%3A+%22{originaltitle}%22%2C+%22year%22%3A+%22{year}&t={now}" } Still having a problem with tv shows so I now have to work on that.

What can you see from the format above?

jurialmunkey commented 2 years ago

Okay so ive got movies working with this: "play_movie": "plugin://plugin.video.theoath/?action=play&title={title}&year={year}&imdb={imdb}&meta=%7B%22title%22%3A+%22{title}%22%2C+%22originaltitle%22%3A+%22{originaltitle}%22%2C+%22year%22%3A+%22{year}&t={now}" } Still having a problem with tv shows so I now have to work on that.

What can you see from the format above?

FYI you'll probably want to use {title_url} and {originaltitle_url} instead to cover movies with special characters like Weekend at Bernie's or Avengers: Infinity War

mrXoo commented 2 years ago

Thanks so much for your patience Iv fixed everything and its working great. If anyone wants it the player I have is here: { "name": "The Oath", "plugin": "plugin.video.theoath", "is_resolvable": "true", "priority": 200, "play_movie": "plugin://plugin.video.theoath/?action=play&title={title_url}&year={year}&imdb={imdb}&meta=%7B%22title%22%3A+%22{title_url}%22%2C+%22originaltitle%22%3A+%22{originaltitle_url}%22%2C+%22year%22%3A+%22{year}&t={now}", "play_episode": "plugin://plugin.video.theoath/?action=play&title={title_url}&year={year}&imdb={imdb}&tvdb={id}&season={season}&episode={episode}&tvshowtitle={clearname_+}&premiered={firstaired}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+{tmdb}%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot_url}%22%2C+%22votes%22%3A+%22%22%2C+%22thumb%22%3A+%22{thumbnail}%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22tvdb%22%3A+%22{id}%22%2C+%22label%22%3A+%22{title_+}%22%2C+%22season%22%3A+%22{season}%22%2C+%22status%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22tvshowtitle%22%3A+%22{clearname_+}%22%2C+%22mediatype%22%3A+%22episode%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22banner%22%3A+%22{thumbnail}%22%2C+%22episode%22%3A+%22{episode}%22%2C+%22premiered%22%3A+%22{firstaired}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dtrailer%26name%3D{clearname_+}%22%7D&t={now}" }

mrXoo commented 2 years ago

actually I get an error on Weekend at Bernie's

Any idea?

mrXoo commented 2 years ago

new 4.txt

jurialmunkey commented 2 years ago

You're missing an %22 endquote after {year} in this part "year": "{year}&t={now} You're also missing a closing curly brace } ie %7D on the meta dictionary

See decoded line:

plugin://plugin.video.theoath/?action=play&title={title_url}&year={year}&imdb={imdb}&meta={"title": "{title_url}", "originaltitle": "{originaltitle_url}", "year": "{year}&t={now}

It should be like the following so that {year} is in quotes and the meta= dictionary is closed before &t={now}

plugin://plugin.video.theoath/?action=play&title={title_url}&year={year}&imdb={imdb}&meta={"title": "{title_url}", "originaltitle": "{originaltitle_url}", "year": "{year}"}&t={now}

Encoded: plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dplay%26title%3D{title_url}%26year%3D{year}%26imdb%3D{imdb}%26meta%3D%7B%22title%22%3A%20%22{title_url}%22%2C%20%22originaltitle%22%3A%20%22{originaltitle_url}%22%2C%20%22year%22%3A%20%22{year}%22%7D%26t%3D{now}

mrXoo commented 2 years ago

this player does work but just when it populates the links it pops up a box Playback failed even before I select a link. How can I fix that? Only did it on weekend at Bernie's { "name": "The Oath", "plugin": "plugin.video.theoath", "is_resolvable": "true", "priority": 200, "play_movie": "plugin://plugin.video.theoath/?action=play&title={title_url+}&year={year}&imdb={imdb}&meta=%7B%22title%22%3A+%22{title_url+}%22%2C+%22originaltitle%22%3A+%22{originaltitle_url}%22%2C+%22year%22%3A+%22{year}%22%7D&t={now}", "play_episode": "plugin://plugin.video.theoath/?action=play&title={title_url}&year={year}&imdb={imdb}&tvdb={id}&season={season}&episode={episode}&tvshowtitle={clearname_+}&premiered={firstaired}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+{tmdb}%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot_url}%22%2C+%22votes%22%3A+%22%22%2C+%22thumb%22%3A+%22{thumbnail}%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22tvdb%22%3A+%22{id}%22%2C+%22label%22%3A+%22{title_+}%22%2C+%22season%22%3A+%22{season}%22%2C+%22status%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22tvshowtitle%22%3A+%22{clearname_+}%22%2C+%22mediatype%22%3A+%22episode%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22banner%22%3A+%22{thumbnail}%22%2C+%22episode%22%3A+%22{episode}%22%2C+%22premiered%22%3A+%22{firstaired}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dtrailer%26name%3D{clearname_+}%22%7D&t={now}" }

jurialmunkey commented 2 years ago

@mrXoo - you need to set "is_resolvable" to "false" -- you've changed it back to true. It needs to be false.

mrXoo commented 2 years ago

Awesome thank you