search

jussi-kalliokoski / gulp-awspublish-router

A router for defining file-specific rules with gulp-awspublish
29 stars 7 forks source link

Fixing #1 #4

Closed jussi-kalliokoski closed 10 years ago

jussi-kalliokoski commented 10 years ago

In issue #1, the problem is that a directory with an empty string as the relative path causes the pipeline to throw an error. Since all instances of files with an empty relative path are directories and can't be processed anyway, I suggested they be ignored.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 8c66d090f157d6ae8505a3184b5f2a1149156cf0 on fix-issue-1 into 331868354b4550f8277cb236d625fad2b3b5949c on master.

jussi-kalliokoski commented 10 years ago

Note that 60bc473 only succeeded because 8c66d09 was pushed before Travis started building the PR.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 85eb9a736016a7e4f37d8f8def603cbaae394638 on fix-issue-1 into 331868354b4550f8277cb236d625fad2b3b5949c on master.

danielnaab commented 10 years ago

+1 for merging this and rev'ing the npm package.

jussi-kalliokoski commented 10 years ago

Merged and released v0.1.0. :) Sorry for the wait on this one, managed to forget about this PR.

danielnaab commented 10 years ago

@jussi-kalliokoski thanks, this tool is making my life much easier at the moment!