justarrived / just-match-frontend

[ABANDONED] Frontend for JustMatch API
https://antrop.invisionapp.com/share/FA62UU66R
MIT License
2 stars 9 forks source link

Bank-BIC alternative should be a link in the description and not a big pink button #623

Closed FivelFred closed 8 years ago

FivelFred commented 8 years ago

To start with, thanks @ti-sedp for implementing this feature. One small alternation I would like to do is to remove the pink button and put the feature into the description as a hypertext.

This is how it looks now:

current bank account details

This is how I want it to look:

future bank account details

FivelFred commented 8 years ago

@lenaar or @pstenstrm could you assist with this one or should I ask SEDP?

lenaar commented 8 years ago

@FivelFred: hi, yes I can, these two days I am at the google summit, will fix it after it. :)

FivelFred commented 8 years ago

OK thanks @lenaar !

FivelFred commented 8 years ago

Have you had time to look into this @lenaar ?

lenaar commented 8 years ago

I have fixed link instead of button, I have to do the whole sentence as the link because it is translatable text, cannot break it for putting link in the middle of it. The whole sentence looks better and it is a standard for assistive technologies to use descriptive text for such things, because we understand that is link specific for this line.

screen shot 2016-07-14 at 15 21 45 screen shot 2016-07-14 at 15 21 59
lenaar commented 8 years ago

Probably we need more descriptive text for cancel, smth like 'Back to Use Bank Swedish Bank'

buren commented 8 years ago

Thanks @lenaar! :tada:

:+1: for a more descriptive "Cancel button".

buren commented 8 years ago

This has been implemented. Thanks again @lenaar