e.Buffer includes old data.

[iron2han]

I need to get some WebSocket data, but the old data always shows up in “DataReceived”. which has never appeared before in other WebSocket connections. I suspect it is a bug.

` public Form1() { InitializeComponent();

        _proxy = new ProxyServer
        {
            ForwardToUpstreamGateway = true
        };

        var explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 8000);
        explicitEndPoint.BeforeTunnelConnectRequest += ExplicitEndPoint_BeforeTunnelConnectRequest;
        _proxy.AddEndPoint(explicitEndPoint);
        _proxy.BeforeResponse += Proxy_BeforeResponse;

        _proxy.Start();

        // proxy.SetAsSystemProxy(explicitEndPoint, ProxyProtocolType.AllHttp);
    }

    private readonly ProxyServer _proxy;

    private async Task Proxy_BeforeResponse(object sender, SessionEventArgs e)
    {
        if (e.HttpClient.ConnectRequest?.TunnelType == TunnelType.Websocket)
        {
            e.DataReceived += E_DataReceived;
        }
    }

    private void E_DataReceived(object sender, DataEventArgs e)
    {
        var args = (SessionEventArgs)sender;
        foreach (var frame in args.WebSocketDecoder.Decode(e.Buffer, e.Offset, e.Count))
        {
            if (frame.OpCode == WebsocketOpCode.Text)
            {
                var request = args.HttpClient.Request;
                var text = frame.GetText();
                Console.WriteLine(text);
                /* Data handler */
            }
        }
    }

`

[honfika]

Which old data? how to reproduce the bug? is there a public website?

[honfika]

Anyway, the "e.Buffer includes old data" is true and it is not a bug. You should use the e.Offset and e.Count parameters.

so e.Buffer contains new and valid data only from position e.Offset... and contains e.Count valid bytes.

[iron2han]

Ok, I just saw. Is this a feature? This problem didn’t appear when I test other WebSocket connections, thus I suspect it’s a bug. Thanks for replying.

[honfika]

Yes, the buffer comes from a bufferpool (official System.Buffer.ArrayPool). which can contain memory garbage.

[iron2han]

Includes old frame data in the results of "args.WebSocketDecoder.Decode()". It is also normal?

code (reference example "ProxyTestController.cs"):

output window:

firefox network debug

[honfika]

No, that is not normal... I've fixed it Please try the latest nuget package (3.1.1288)

[iron2han]

It is normally working.

[honfika]

Ok, then I close this issue. feel free to reopen if needed.