search

justin025 / onthespot

OnTheSpot is an easy-to-use music downloader built with Python and Qt. Search for songs, albums, or playlists and download them directly to your device.
GNU General Public License v2.0
138 stars 14 forks source link

High memory Usage #53

Open solunafantasy opened 2 weeks ago

solunafantasy commented 2 weeks ago

Feature Description

I am seeing extreme memory usage, more notable when adding 2.5K songs in queue. I first noticed this when Spotify and browsers crashed due to being out of memory, ( I don't normally use a page-file, I have 32GB of RAM)

Justification

Better memory management will avoid systemwide issues/improve performance. This is Windows 11, latest patch and 1.0.2. I am unsure if other versions are affected. I only noticed this after loading a larger then usual list. (since that seems to be working now)

Additional Information

memory
solunafantasy commented 2 weeks ago

In the Interm, I have added 64GB of page-file on an SSD to mitigate to continue operation. I also have stopped adding songs until the current queue is exhausted. (I believe i have 5-6k still being added) Obviously not optimal but will allow the app to run for now. It would be a major PIA to requeue everything. I could imagine that this will degrade the app once it starts being utilized.

justin025 commented 2 weeks ago

Does the amount stay high until the app is closed or does clearing items in the download queue fix the issue. On Sunday, November 10th, 2024 at 9:30 AM, solunafantasy @.***> wrote:

In the Interm, I have added 64GB of page-file on an SSD to mitigate to continue operation. Obviously not optimal but will allow the app to run for now. I could imagine that this will degrade the app once it starts being utilized.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

solunafantasy commented 2 weeks ago

It drops from 20GB to 13GB of ram after I clear completed downloads. Apologies it took so long to respond, i was afk all day. Surprisingly, it never crashed. Keep in mind only a third of the queue completed and its continuing to download.

0rkaM commented 2 weeks ago

Why on Task Manager says you have two instances running? Mine even when is in the middle of downloading, or creating the file, it shows only one instance. And in my case, I cannot reproduce, even with a list of over 300+ queued songs, it does not go much over 260mb: OtS 1 0 2 max download 400 song playlist no memory problem 2 I save file as OGG, I wonder if maybe you are using another format and that is where it happens.

solunafantasy commented 2 weeks ago

Why on Task Manager says you have two instances running? Mine even when is in the middle of downloading, or creating the file, it shows only one instance. And in my case, I cannot reproduce, even with a list of over 300+ queued songs, it does not go much over 260mb: OtS 1 0 2 max download 400 song playlist no memory problem 2 I save file as OGG, I wonder if maybe you are using another format and that is where it happens.

Microsoft Edge.......

Anyway, I am not sure, possibly because I renamed the file?