justinlatimer / node-midi

A node.js wrapper for RtMidi providing MIDI I/O
MIT License
745 stars 119 forks source link

Increase buffer size #191

Closed halfbyte closed 3 years ago

halfbyte commented 3 years ago

@justinlatimer As promised via Email, here's a simple change that doubles the buffer size for sysex messages - We had to change this to make the module work with a couple of Novation/Focusrite devices that use bigger sysex messages as means to speed up transfer.

This should be fine in most contexts, initially we just wondered if this maybe should be something user configurable.

justinlatimer commented 3 years ago

Hey @halfbyte - Ideally I'd like to keep the version of RtMidi direct from upstream. I've raised a PR against RtMidi directly to try and get the simplest possible change in that would allow node-midi to define the buffer size in it's build. I'll wait to see if I can get traction on that PR and if not we can probably import RtMidi from my fork.

justinlatimer commented 3 years ago

Fixed via #193 and published as v1.0.4.