Make native module context-aware

justinlatimer / node-midi

A node.js wrapper for RtMidi providing MIDI I/O

MIT License

745 stars 119 forks source link

Make native module context-aware #213

Open wookayin opened 3 years ago

wookayin commented 3 years ago

Electron 14.0+ requires the module to be context-aware to be importable.

Fixes #164 References: electron/electron#18397

adammeyer commented 2 years ago

Thanks for adding support for new Electron versions.

When building with Electron 16, I'm getting this error: *** No rule to make target `Release/obj.target/midi/vendor/rtmidi/RtMidi.o', needed by `Release/midi.node'. Stop.

Julusian commented 2 years ago

I have opened a PR to do an overhaul of this library which includes an alternate solution to this (#228) As it doesn't look like there are any maintainers around to merge it, I shall be maintaining a fork which is 100% api compatible https://www.npmjs.com/package/@julusian/midi