search

justinmahar / react-social-media-embed

📰 Easily embed social media posts from Facebook, Instagram, LinkedIn, Pinterest, TikTok, X (Twitter), and YouTube in React.
https://justinmahar.github.io/react-social-media-embed/
MIT License
215 stars 30 forks source link

Update all pacakges and remove generateUuid #51

Closed vip30 closed 11 months ago

vip30 commented 1 year ago

Replace generateUuid by useId

fix

https://github.com/justinmahar/react-social-media-embed/issues/7 https://github.com/justinmahar/react-social-media-embed/issues/40

justinmahar commented 11 months ago

@vip30 Awesome, will be addressing this PR this weekend

justinmahar commented 11 months ago

First I've learned of React.useId(), so much nicer

justinmahar commented 11 months ago

I reviewed these and they looked good, but had to revert the changes, unfortunately. They broke the Storybook build, see https://github.com/justinmahar/react-social-media-embed/pull/55

justinmahar commented 11 months ago

Did this run or build for you locally? The issue occurs with both npm start and in production (GitHub Pages).

vip30 commented 11 months ago

Lemme try for storybook We already use the fixed commit in production so should be ok for the plugin itself

vip30 commented 11 months ago

should be ok now @justinmahar, just missing to update those mdx files.