search

justinmc / react-audio-player

A simple React wrapper on the HTML5 audio tag
MIT License
587 stars 103 forks source link

TS: Set all Event props as optional #99

Closed AntonyHatchet closed 3 years ago

AntonyHatchet commented 3 years ago

Hi, many thanks for your work.

I found that all Event required in ReactAudioPlayerProps. But in fact, they are not necessary to work with the player.

Maybe you will found this small change helpful.

image

justinmc commented 3 years ago

Thanks for the contribution and sorry I missed this! You're right that these should be optional. The TypeScript support was added quickly awhile back.