justinmeiners / classic-colors

Paint program for Unix. Inspired by MS Paint (Windows 95-98).
GNU General Public License v2.0
46 stars 3 forks source link

A pull request #18

Closed MagnetarRocket closed 2 years ago

MagnetarRocket commented 2 years ago

Add HTML-help, adding graphicsmagick to the build icons requirements, a mac os screenshot, and a Shapes Icon

justinmeiners commented 2 years ago

I appreciate the contribution. I am noticing some changes as you go so let me know when it's ready.

Here are some thoughts:

justinmeiners commented 2 years ago

Is there anything I need to do on this, or are you still working?

MagnetarRocket commented 2 years ago

A review. My thoughts on what you said are:

I appreciate the contribution. I am noticing some changes as you go so let me know when it's ready.

Here are some thoughts:

  • we also support .tga and .bmp (now fixed).
  • does this help html tie into the system in anyway? If not, I would prefer the folder to be called docs/ or help/. Should we install this with the program in a standard unix location?
  • If you have any better suggestions for tool tips, please make the change in the code.
  • What is the plan for the shapes icon?

mockup of what i'm thinking about: HelpMockup

justinmeiners commented 2 years ago

Looks good! I am really grateful for making this better. I have some edits, but am going to merge it it.

my main thought was of an simple legacy HTML compatible help page

I added a submenu to help that opens this page. Great idea. Love the classic look.

PolygonShapes

A separate PR would be good. I need to get around to programming that feature too!

manpage mockup

Makes sense. I like the HTML but am unsure how useful a detailed man page would be. I think the man page should just tell them about the command line options, provide author and website information, and direct them to the HTML.