search

justinsalamon / scaper

A library for soundscape synthesis and augmentation
BSD 3-Clause "New" or "Revised" License
382 stars 56 forks source link

Bug in `generate_from_jams` when `save_isolated_events` is True, and a `trim` operation was called prior to generating. #113

Closed pseeth closed 4 years ago

pseeth commented 4 years ago

Through some happenstance, I noticed that this will happen here:

https://github.com/justinsalamon/scaper/blob/33def127bf17cdec3858b868538ee4ea41bd0dde/scaper/core.py#L181-L196

Should be easy to fix. audio_outfile should be audio_file here. I'll make a test, get it to fail, then issue a fix in a PR.

justinsalamon commented 4 years ago

Fixed via #115