justinsalamon / scaper

A library for soundscape synthesis and augmentation
BSD 3-Clause "New" or "Revised" License
382 stars 56 forks source link

Create more regression data for #132 + other test strengthening #134

Open pseeth opened 4 years ago

pseeth commented 4 years ago

We need more regression data for #132 to make sure we don't break these changes in future PRs.

Namely, these comments in the CR should be addressed:

justinsalamon commented 4 years ago

Also, we should specifically add tests that combine clipping + reverb, to make sure the two operations work well in for the order in which they are applied (in all likelihood we'll start with applying reverb BEFORE peak normalization)