Open pseeth opened 4 years ago
Also, we should specifically add tests that combine clipping + reverb, to make sure the two operations work well in for the order in which they are applied (in all likelihood we'll start with applying reverb BEFORE peak normalization)
We need more regression data for #132 to make sure we don't break these changes in future PRs.
Namely, these comments in the CR should be addressed: