search

justmoon / node-bignum

Big integers for Node.js using OpenSSL
419 stars 116 forks source link

Fix deprecation warnings #105

Closed adaxi closed 6 years ago

adaxi commented 6 years ago

This pull request updates Nan to the latest version and fixes the deprecation warnings.

Note: I am a beginner at this. Tests pass. I am pretty confident in the patch, except at:

https://github.com/justmoon/node-bignum/pull/105/files#diff-aea5ac9d873a4cf693091c97c0432e66R387

Perhaps someone more experience can tell me if what is did is enough.

adaxi commented 6 years ago

By the way, tests on 0.10 seem to fail because standard does not run on those versions. Should we remove standard from the test list? Or ignore that 0.10 and 0.12 are failing?

vladikoff commented 6 years ago

@justmoon @rvagg is there time to look at this for node 8 and 10?

adaxi commented 6 years ago

OpenSSL 1.1.0 is now bundled with Node 10 instead of OpenSSL 1.0.2, which breaks compatibility.

rvagg commented 6 years ago

ack

sorry, a bit bogged down, I'll try and get a look at this soon! feel free to bug me here if you don't hear from me again (it could very well get lost in my sprawling queue!)

vladikoff commented 6 years ago

@rvagg pinging again. I'm guessing at some point this lib will be deprecated, once node 12 or whatever has BigInts?

vladikoff commented 6 years ago

So just need to maintain it a bit more :D

vladikoff commented 6 years ago

ping @rvagg

rvagg commented 6 years ago

I pulled in #112 for v10 support and to fix some of these problems. Have a go with that.