search

juxtalearn / clipit

ClipIt Repository
GNU Affero General Public License v3.0
5 stars 4 forks source link

It is possible to assign students to a non-existent activity-id via webservices #17

Open nmalzahn opened 10 years ago

nmalzahn commented 10 years ago

It is possible to create a relation between a student and a non-existent activity (-id) via activity.add_students

Existence must be checked by this method. It should neither return 0 nor should it actually create the relation between the student_id and the activitiy_id.

pebs74 commented 10 years ago

Yes, there are quite a lot of error checks to be made. We'll try to incorporate them ASAP.

Pablo Llinás Arnaiz [image: Facebook] https://facebook.com/pebs74 [image: Twitter] https://twitter.com/pebs74 [image: LinkedIn] http://linkd.in/1r7YiJY [Skype] pebs85 [Gmail] pebs74

2014-08-21 11:36 GMT+02:00 nmalzahn notifications@github.com:

It is possible to create a relation between a student and a non-existent activity (-id) via activity.add_students

Existence must be checked by this method. It should neither return 0 nor should it actually create the relation between the student_id and the activitiy_id.

— Reply to this email directly or view it on GitHub https://github.com/juxtalearn/clipit/issues/17.

pebs74 commented 10 years ago

Internal note: Mantis ticket #103