search

jvalue / jayvee

Jayvee is a domain-specific language and runtime for automated processing of data pipelines
https://jvalue.github.io/jayvee/
150 stars 15 forks source link

fix(FilePicker): path can now start with a dot #544

Closed TungstnBallon closed 7 months ago

TungstnBallon commented 7 months ago

paths inside FilePicker can now start with a dot

block DataPicker oftype FilePicker {
    path: "./data.csv";
}

closes #381

rhazn commented 7 months ago

(In case you'd like me to review this again, please re-request a review on the top right @TungstnBallon :)).

georg-schwarz commented 7 months ago

Hey @TungstnBallon,

Sorry that this happened the second time now, but there has been a refactoring again :sweat_smile:

545 renamed all occurrences of "blocktype" to "blockType", it probably affects some of your imports.

546 enforces the use of type imports where possible; the auto-fix feature of eslint should be pretty helpful here.

Let me know if I can help updating the branch ;-)

TungstnBallon commented 7 months ago

is there an advantage to putting the tests in a separate pull request? @rhazn