jvandemo / generator-angular2-library

Yeoman generator to create an Angular library
MIT License
752 stars 122 forks source link

Angular version is 4 when selecting jest as test framework #241

Closed apeter10 closed 6 years ago

apeter10 commented 7 years ago

Hi,

I create a package with generator and I found when the test framework is jest, the Angular version is 4. Here's devDependencies of the package.json

"devDependencies": {
    "@angular/common": "^4.0.0",
    "@angular/compiler": "^4.0.0",
    "@angular/compiler-cli": "^4.0.0",
    "@angular/core": "^4.0.0",
    "@angular/platform-browser": "^4.0.0",
    "@angular/platform-browser-dynamic": "^4.0.0",
    "@compodoc/compodoc": "^1.0.0-beta.10",
    "@types/node": "~6.0.60",
    "@types/jest": "^19.2.3",
    "angular-in-memory-web-api": "^0.3.2",
    "codelyzer": "~2.0.0",
    "concurrently": "^3.4.0",
    "core-js": "^2.4.1",
    "del": "^2.2.2",
    "gulp": "^3.9.1",
    "gulp-rename": "^1.2.2",
    "gulp-rollup": "^2.11.0",
    "jest": "^20.0.3",
    "jest-preset-angular": "^2.0.2",
    "lite-server": "^2.3.0",
    "node-sass": "^4.5.2",
    "node-sass-tilde-importer": "^1.0.0",
    "node-watch": "^0.5.2",
    "protractor": "~5.1.0",
    "rollup": "^0.41.6",
    "run-sequence": "^1.2.2",
    "rxjs": "^5.1.0",
    "systemjs": "^0.20.12",
    "ts-node": "~2.0.0",
    "tslint": "~4.5.0",
    "typescript": "~2.2.0",
    "zone.js": "^0.8.4"
  },

But when test framework is karma + jasmine, the Angular version is 5. Is this a bug?

izifortune commented 6 years ago

We are keeping two different packages json so they might be not aligned I will look into it

izifortune commented 6 years ago

PR is pending #267

jvandemo commented 6 years ago

PR has been merged.

@apeter10 — Thank you for reporting.

@izifortune — Thank you for the fix 👍