search

jvandemo / generator-angular2-library

Yeoman generator to create an Angular library
MIT License
752 stars 122 forks source link

force user to use node 8.x to use util.promisify #276

Open aelbore opened 6 years ago

aelbore commented 6 years ago

since 8.x is the LTS version for node, why not change the promisify function to require('util').promisify

jvandemo commented 6 years ago

@aelbore — What would be the benefit from a user's perspective? I'm guessing some people still use node v6. What would be the benefit of forcing them to use node v8? Thanks in advance!

aelbore commented 6 years ago

@jvandemo i notice that your using promisify to make the fs.readfile to promise, and also since node v8 is the LTS version in a few months theres no support for v6. async/await to make code shorter.

aelbore commented 6 years ago

@jvandemo by the way i got lightweight cli to bundle angular as a package. you might consider this also. https://github.com/ngx-devtools/cli or just npm install -g @ngx-devtools/cli then ngx run bundle thanks.

izifortune commented 6 years ago

I wouldn't see any problems about dropping the support for node v6

jvandemo commented 6 years ago

@aelbore — Would you be interested in creating a PR to update the code to node v8? Thanks!

aelbore commented 6 years ago

@jvandemo sure will create a PR :)