jw3 / example-daffodil-vscode

A VS Code extension for DFDL with Daffodil

Apache License 2.0

2 stars 3 forks source link

Closed shanedell closed 3 years ago

shanedell commented 3 years ago

Create github action that will run yarn run lint -- The Unit tests CI actually already fails if their are linting issues so no need to create a seperate one (file removed from repo)
Create fix-lint in script package.json, so that the user can just run yarn run fix-lint and all of the lint issues will be fixed.
Updated the .eslintrc.json to have a rule for indents. This file can be updated with more rules for more specific code checking.

99

jw3 commented 3 years ago

Linting is great, but we need a better formatter for #99.

jw3 commented 3 years ago

Can set VS Code to format on save, which is ideal for now.

Might want a CI check for formatting too, but that can wait if its not a drop in simple thing to do.

jw3 commented 3 years ago

I was playing around with prettier, will do separate PR