search

jwallet / spy-spotify

🎤 Records Spotify to mp3 without ads and adds media tags to the files 🎵
https://jwallet.github.io/spy-spotify/
MIT License
2.1k stars 139 forks source link

If SpotifyAPI fails, do not use LastFM, end the session #483

Open welles opened 1 year ago

welles commented 1 year ago

I've been running some overnight unattended recording sessions and several times during the sessions Spytify has asked me to re-authorize the app with Spotify API by opening the browser window. Because I was not at the machine the timeout for the authorization of course ran out.

I don't know if this loss of authorization is a problem on Spotify's side, but what was definitely unfortunate was that Spytify just silently switched to the LastFM ID3 API and continued recording without indicating in the log or anywhere else in the UI that this had occured, which meant I could not easily see when the app had switched the API or which songs had been tagged by LastFM since then.

I would love it if there was an obvious error message when the authorization failed and an option in the settings to stop spying (and maybe Spotify playback?) when it happens.

welles commented 1 year ago

Correction: Apparently there is a popup that tells you when the authorization fails. No idea how I missed that! Still, I would prefer it if Spytify would stop spying when it happens instead of just continuing with LastFM.