jwalton512 / vim-blade

Vim syntax highlighting for Blade templates.
225 stars 37 forks source link

Regression, which testing didn't catch #18

Closed tremby closed 10 years ago

tremby commented 10 years ago

Sadly it seems the synchk method of testing is not robust. :(

In the latest commit 342a5916 various parts of the test cases no longer highlight properly, even though the tests say they pass.

Two such snippets are in the following:

@if ($document->getMyText('phone') && $document->getMyText('email'))
    or
@endif
@if (count($records) > 0)
    <p>I have records!</p>
@elseif (count($records) < 0)
    <p>I owe records!</p>
@endif

which currently looks like this:

screen shot 2014-03-13 at 10 36 05 am

On b494405 it looks like this:

screen shot 2014-03-13 at 10 36 34 am

Tests pass on both, so sadly it looks like they can't be relied upon. I'll make a separate ticket for doing something about that.