jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
829 stars 68 forks source link

Async bytecomp broken on Emacs master: `Invalid read syntax: "#"` #188

Closed Stebalien closed 4 months ago

Stebalien commented 4 months ago

On Emacs master, invoking async-byte-compile-file fails with:

error in process sentinel: async-when-done: Invalid read syntax: "#"
error in process sentinel: Invalid read syntax: "#"

I've narrowed this down to the recent obarray changes (https://github.com/emacs-mirror/emacs/commit/6803b70c1972bc82f7dc1f1d6bbb2a60b6f40367 and the following commit).

thierryvolpiatto commented 4 months ago

Steven Allen @.***> writes:

On Emacs master, invoking async-byte-compile-file fails with:

error in process sentinel: async-when-done: Invalid read syntax: "#" error in process sentinel: Invalid read syntax: "#"

I can't reproduce here, with a build of yesterday night.

I've narrowed this down to the recent obarray changes @.*** and the following commit).

This commit doesn't modify code, only docs AFAICT.

-- Thierry

Stebalien commented 4 months ago

Ah, sorry, the previous commits: 462d8ba813e07a25b71f5c1b38810a29e21f784c, 3ea77c735de975ebda707e0e1e8bb5e0adad2bf5.

I tested by building:

thierryvolpiatto commented 4 months ago

I see these commits:

Capture d’écran_2024-02-27_20-51-15

My build has these commits but I still can't reproduce, perhaps you could provide the file you are trying to compile?

Stebalien commented 4 months ago

Ah... I was injecting my native-comp-* variables via async-bytecomp-load-variable-regexp (doesn't appear to be necessary anymore) and some variable with that prefix probably broke.

As usual, I should have tested with a clean config... Sorry for wasting your time.