jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
829 stars 68 forks source link

Some tests on Macos and Windows are failing #190

Open thierryvolpiatto opened 3 weeks ago

thierryvolpiatto commented 3 weeks ago

Hello @Fuco1, after each commit I receive a mail saying build fails on several platforms: https://github.com/jwiegley/emacs-async/actions/runs/9542738192/job/26298070538#step:3:334 An idea of what's wrong?

Fuco1 commented 3 weeks ago

The macos tests seem to not provide older emcas versions anymore:

  error: flake 'github:purcell/nix-emacs-ci' does not provide attribute 'packages.aarch64-darwin.emacs-27-2', 'legacyPackages.aarch64-darwin.emacs-27-2' or 'emacs-27-2'
         Did you mean one of emacs-28-2, emacs-29-2, emacs-28-1, emacs-29-1 or emacs-29-3?

maybe @purcell can weigh in?

About the windows tests, there seems to be some issue with the code. I'll have to figure out a way to run the windows tests locally though :O

purcell commented 3 weeks ago

This is because macos-latest is now ARM (Apple Silicon), and only Emacs >= 28.2 build on that platform. For a while, it would be possible to include macos-11 to get Intel builds, but GitHub is soon going to remove those runners. So the solution here is, unfortunately, to stop expecting MacOS builds on earlier Emacs versions.

purcell commented 3 weeks ago

BTW, easiest mechanism would be use exclude in the matrix portion of the github workflow, see https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

thierryvolpiatto commented 3 weeks ago

Thanks Matus and Steve to look into this!

thierryvolpiatto commented 5 days ago

@jwiegley could you disable this mechanism in github actions until it be fixed?

jwiegley commented 5 days ago

It should be disabled now.

thierryvolpiatto commented 5 days ago

John Wiegley @.***> writes:

It should be disabled now.

Great, thanks.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.*Message ID: @.***>

-- Thierry

purcell commented 5 days ago

I took a stab at fixing this -> #191