jwilk-archive / pdf2djvu

PDF to DjVu converter
GNU General Public License v2.0
94 stars 17 forks source link

Current master requires C++17 to compile #155

Closed spaskalev closed 2 years ago

spaskalev commented 2 years ago

The README states that it needs c++11 but it will fail to compile with it. Adding -std=c++17 to CXXFLAGS in autoconf.mk makes it compile successfully.

jwilk commented 2 years ago

I believe pdf2djvu proper requires only C++11, as documented. Some of the required libraries may have stricter requirements, though. For example, recent versions of Poppler (≥ 22, I think) require C++17. This is most likely why you're seeing build errors.

spaskalev commented 2 years ago

You are right, the compilation errors are indeed reported for poppler includes. Nevertheless, if works great with C++17 too :) - I've contributed a package for it for Void Linux and it is now available - https://github.com/void-linux/void-packages/commit/40be1cbf1bd62492c36df292bffd172d05fbe2eb

Cheers!