search

jx3-gitops-repositories / jx3-terraform-eks

Jenkins X 3.x Infrastructure Git Template for Terraform and EKS for managing cloud resources
Apache License 2.0
9 stars 41 forks source link

Update to the method for setting defaults for cluster? #9

Closed seczetta-jenkins-bot closed 3 years ago

seczetta-jenkins-bot commented 3 years ago

The current README has this section:

Override the variable defaults in the Infrastructure repository. (E.g, edit variables.tf, set TF_VAR_ environment variables, or pass the values on the terraform command line.)

region: AWS region code for the AWS region to create the cluster in.
jx_git_url: URL of the Cluster repository.
jx_bot_username: The username of the git bot user

It looks like this should now turn into definitions in jx-requirements,yml, can you confirm? That looks like the pattern, though the only one of the above three variables I see being fetched is "region."

I prefer putting settings into files over setting environment variables, but I'll try the latter if I don't hear back on this relatively soon... thanks.

seczetta-jenkins-bot commented 3 years ago

Ah, never mind. The context for the variable settings switched back to the terraform repo, where I see the files to change... closing the issue.