search

jyaus / swimlanes-for-trello

Support arranging Trello lists into horizontal swimlanes
32 stars 3 forks source link

Addon icon does not show up on Firefox. #10

Open ClarkAllen1556 opened 4 years ago

ClarkAllen1556 commented 4 years ago

On Firefox the addon is placed in the address-bar but has no icon. Instead it gets the default Firefox placeholder.

キャプチャ

According to Mozilla's docs, Firefox address-bar buttons need their icon specified in the manifest.json:

"page_action": {
  "browser_style": true,
  "default_icon": { // <----- HERE
    "19": "button/geo-19.png",
    "38": "button/geo-38.png"
  },
  "default_title": "Whereami?"
}

This can be fixed with: 

// ...
"page_action": {
    "default_title": "Swimlanes for Trello",
    "default_icon": {
      "48": "icon48.png" // <----- THIS
    }
  }

This issue does not exist on Chrome as the button seems to not be placed in the address bar; this fix does not effect the Chrome version at all.

jyaus commented 4 years ago

Love it. Thank you! Publishing a new version of the extension is a bit of a PITA, but as someone who uses Firefox as a primary browser, I hope to do so soon.