search

k-int / gokb-phase1

Original GOKb repo - Moving to https://github.com/openlibraryenvironment/gokb
http://www.gokb.org
Other
11 stars 5 forks source link

Cannot edit title fields as an Editor or Contributor, only Admin #594

Closed jhsolomon closed 7 years ago

jhsolomon commented 7 years ago

The "Empty" fields do not allow Editors and Contributors to make changes to the title records. I had a user contact me with this problem today. Could you take a look at the roles to see that everything is enabled correctly?

This is what it looks like when I log in as a Contribtor: image

As an Admin: image

ianibo commented 7 years ago

Non admin users can only edit an item if they belong to a curatory group that the item belongs to. So if a title belongs to NCSU then the user must also belong to NCSU. We don't currently have any way to set curatory groups for titles, so all titles have no curatory groups, and, hence only admins can edit titles. I think it's pretty much always been this way - at least since we introduced curatory groups. One to discuss on friday.

jhsolomon commented 7 years ago

Ok, interesting. This was not the case before because we had our volunteers, who are not Admins, editing title records as part of the title history work, including publication dates, status, title details, alternative names, etc.

So yes, let's discuss on Friday. Thanks!

On Thu, Feb 2, 2017 at 3:44 AM, Ian Ibbotson notifications@github.com wrote:

Non admin users can only edit an item if they belong to a curatory group that the item belongs to. So if a title belongs to NCSU then the user must also belong to NCSU. We don't currently have any way to set curatory groups for titles, so all titles have no curatory groups, and, hence only admins can edit titles. I think it's pretty much always been this way - at least since we introduced curatory groups. One to discuss on friday.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-276899040, or mute the thread https://github.com/notifications/unsubscribe-auth/AMwAJZzlU45vpB0YuWBj3adGPg6l3NQFks5rYZdcgaJpZM4L0S2J .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

ianibo commented 7 years ago

Yeah - quick check - can you please look at the "domains" search - and see in the config if ROLE_USER has edit rights under JournalInstance (Rather than the old TitleInstance)?

Does this behavior happen on anything other than titles, or is it only happening on titles?

jhsolomon commented 7 years ago

This is only happening on titles, as far as I can tell. With the pacakges, it will allow me as an Editor to go into the edit mode, when I click the button to ackknowledge that this package is owned by a certain curatory group. Only Admins can edit Orgs.

I don't see ROLE_USER under domains, so maybe I am looking in the wrong place. For UserRole, nothing is turned on.

[image: Inline image 1]

On Thu, Feb 2, 2017 at 11:35 AM, Ian Ibbotson notifications@github.com wrote:

Yeah - quick check - can you please look at the "domains" search - and see in the config if ROLE_USER has edit rights under JournalInstance (Rather than the old TitleInstance)?

Does this behavior happen on anything other than titles, or is it only happening on titles?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277008847, or mute the thread https://github.com/notifications/unsubscribe-auth/AMwAJdUDH7sQc9WQu8SMG9zeozAypBSwks5rYgXCgaJpZM4L0S2J .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

jhsolomon commented 7 years ago

Ok, I was looking at the wrong item. But no, it's turned on here either.

[image: Inline image 1]

On Thu, Feb 2, 2017 at 12:58 PM, Jennifer Solomon jhsolomo@ncsu.edu wrote:

This is only happening on titles, as far as I can tell. With the pacakges, it will allow me as an Editor to go into the edit mode, when I click the button to ackknowledge that this package is owned by a certain curatory group. Only Admins can edit Orgs.

I don't see ROLE_USER under domains, so maybe I am looking in the wrong place. For UserRole, nothing is turned on.

[image: Inline image 1]

On Thu, Feb 2, 2017 at 11:35 AM, Ian Ibbotson notifications@github.com wrote:

Yeah - quick check - can you please look at the "domains" search - and see in the config if ROLE_USER has edit rights under JournalInstance (Rather than the old TitleInstance)?

Does this behavior happen on anything other than titles, or is it only happening on titles?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277008847, or mute the thread https://github.com/notifications/unsubscribe-auth/AMwAJdUDH7sQc9WQu8SMG9zeozAypBSwks5rYgXCgaJpZM4L0S2J .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 <(919)%20515-2743> j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

ianibo commented 7 years ago

This is the page I'm talking about::

https://gokb.openlibraryfoundation.org/gokb/resource/show/org.gokb.cred.KBDomainInfo%3A473

Can you try setting ROLE_USER to Read, Write, Create -- well - whatever you want them to be able to do? Ditto for other roles you would like to be able to do those things?

ianibo commented 7 years ago

(Screencap of current perms) image

jhsolomon commented 7 years ago

Ok, updated now.

[image: Inline image 1]

On Thu, Feb 2, 2017 at 1:15 PM, Ian Ibbotson notifications@github.com wrote:

(Screencap of current perms) [image: image] https://cloud.githubusercontent.com/assets/53283/22562211/7f4b8dd0-e973-11e6-9804-2d32476cb781.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277037011, or mute the thread https://github.com/notifications/unsubscribe-auth/AMwAJdzby7fVAvtre2mFQbc-k6PUUpNjks5rYh0mgaJpZM4L0S2J .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

ianibo commented 7 years ago

Did it make any difference? I'm guessing not then?

On 2 February 2017 at 18:19, jhsolomon notifications@github.com wrote:

Ok, updated now.

[image: Inline image 1]

On Thu, Feb 2, 2017 at 1:15 PM, Ian Ibbotson notifications@github.com wrote:

(Screencap of current perms) [image: image] https://cloud.githubusercontent.com/assets/ 53283/22562211/7f4b8dd0-e973-11e6-9804-2d32476cb781.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277037011 , or mute the thread https://github.com/notifications/unsubscribe- auth/AMwAJdzby7fVAvtre2mFQbc-k6PUUpNjks5rYh0mgaJpZM4L0S2J .

-- Jennifer Solomon GOKb Editor, Acquisitions and Discovery North Carolina State University Libraries 919-515-2743 <(919)%20515-2743> j kristen_wilson@ncsu.eduhsolomo@ncsu.edu

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277038155, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQIyw4eBM4Fo62Y_G-H4m4OWlfggWJks5rYh4egaJpZM4L0S2J .

-- Ian Ibbotson W: http://ianibbo.me E: ianibbo@gmail.com skype: ianibbo twitter: ianibbo GoodReads: https://www.goodreads.com/user/show/3106516-ian-ibbotson

jhsolomon commented 7 years ago

Sorry, yes, I should have closed this. It's working now!

ianibbo commented 7 years ago

Awesome :) Cheers - apols for the confusion - mea culpa!

Ian Ibbotson Director Knowledge Integration Ltd 35 Paradise Street, Sheffield. S3 8PZ T: 0114 273 8271 M: 07968 794 630 W: http://www.k-int.com Doodle: http://doodle.com/ianibbo

On 2 February 2017 at 23:27, jhsolomon notifications@github.com wrote:

Sorry, yes, I should have closed this. It's working now!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/k-int/gokb-phase1/issues/594#issuecomment-277117789, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfzdVbMkEyxFiVqviIhAAubwZ_FXXEMks5rYmZTgaJpZM4L0S2J .