search

k0sproject / k0smotron

k0smotron
https://docs.k0smotron.io/
Other
508 stars 48 forks source link

`K0sControlPlane` ctrl sets ready status too early #765

Closed jnummelin closed 1 month ago

jnummelin commented 1 month ago 
% kubectl -n capv-clusters get machine
NAME              CLUSTER   NODENAME   PROVIDERID   PHASE          AGE   VERSION
from-cc-mq248-0   from-cc                           Provisioning   53s   v1.29.1
from-cc-mq248-1   from-cc                           Pending        53s   v1.29.1
from-cc-mq248-2   from-cc                           Pending        53s   v1.29.1
% kubectl -n capv-clusters get k0scontrolplane from-cc-mq248 -o json | jq .status
{
  "controlPlaneReady": true,
  "externalManagedControlPlane": false,
  "initialized": true,
  "ready": true,
  "replicas": 3,
  "version": "v1.29.1+k0s.0"
}

We probably should not post ready state this early. In this example the first VM is actually just being provisioned.

apedriza commented 1 month ago

@jnummelin is this still an issue after https://github.com/k0sproject/k0smotron/pull/774 integration? should we close it?

jnummelin commented 1 month ago

Yeah, can be closed