k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home
https://docs.k8s-at-home.com
Apache License 2.0
1.45k stars 621 forks source link

Migrate charts to common v3 #942

Closed bjw-s closed 3 years ago

bjw-s commented 3 years ago

Details

The following charts need to be upgraded to the latest version of the common library. Since this is a mostly manual task, we'll track the progress here

To Do:

All done 🙂

Done:

nicholaswilde commented 3 years ago

I haven't looked yet, but does the template chart need to be updated? I use the template as a base/example when updating charts.

bjw-s commented 3 years ago

I haven't looked yet, but does the template chart need to be updated? I use the template as a base/example when updating charts.

Good call! I'll do that one right now :)

bjw-s commented 3 years ago

@nicholaswilde The template has been updated 👍

angelnu commented 3 years ago

@bjw-s - just checking - the expectation is that each of the mainteiners update theirs with their PR and then check the box, right?

Beyond the removal of the additionalVolumes - anything else we need to pay attention to?

bjw-s commented 3 years ago

@bjw-s - just checking - the expectation is that each of the mainteiners update theirs with their PR and then check the box, right?

Not necessarily, anyone can pick up any chart. Ideally it would be the/a maintainer, but they can always chime in on the PR.

Beyond the removal of the additionalVolumes - anything else we need to pay attention to?

service and ingress now have a main subkey now to handle the main Service and Ingress

angelnu commented 3 years ago

Thanks for the 3.0.1 - it enabled me to update the pod-gateway. Nice rework!

Will do my other charts next and then will see if I can help with the rest.

bjw-s commented 3 years ago

Silly Github autoclosing.... I guess that will happen more frequently on this one 😓

onedr0p commented 3 years ago

Good work everyone. closing this issue :)