search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

cni-plugin.md: document "mtu" and "trunk" #104

Closed jsquyres closed 4 years ago

jsquyres commented 4 years ago

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Trivial update to cni-plugin.md documentation file.

Which issue(s) this PR fixes:

Does not fix any issue.

Special notes for your reviewer:

I am a first time contributor. I only found the process stuff (e.g., formatting the PR description) from the bot comments after I initially filed this PR. Additionally, there's no .github directory in this repo with a PR template, etc. I had to get this template from https://github.com/kubernetes/kubernetes.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

ovirt-infra commented 4 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.
kubevirt-bot commented 4 years ago

Hi @jsquyres. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

/ok-to-test

phoracek commented 4 years ago

/release-note-none

kubevirt-bot commented 4 years ago

@jsquyres: The label(s) kind/documentation cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kubevirt/ovs-cni/pull/104): >**What type of PR is this?** > >/kind documentation > >**What this PR does / why we need it**: > >Trivial update to cni-plugin.md documentation file. > >**Which issue(s) this PR fixes**: > >Does not fix any issue. > >**Special notes for your reviewer**: > >I am a first time contributor. I only found the process stuff (e.g., formatting the PR description) from the bot comments after I initially filed this PR. Additionally, there's no `.github` directory in this repo with a PR template, etc. I had to get this template from https://github.com/kubernetes/kubernetes. > >**Does this PR introduce a user-facing change?**: > >```release-note >NONE >``` >**Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.**: > >```docs > >``` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

Sorry about the bots. We just recently integrated prow into this repo and it has some loose ends.

jsquyres commented 4 years ago

Sorry about the bots. We just recently integrated prow into this repo and it has some loose ends.

No worries! They were actually quite helpful in understanding the process.

phoracek commented 4 years ago

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsquyres, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment