search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

add test flags to make functest more readable #122

Closed RamLavi closed 4 years ago

RamLavi commented 4 years ago

Let's add test flags for better visability We do that by -test.v verbose flag and E2E_TEST_ARGS flag to be able to disable ginkgo colors when running on prow.

Signed-off-by: Ram Lavi ralavi@redhat.com

RamLavi commented 4 years ago

/release-note-none

RamLavi commented 4 years ago

@phoracek do you think I should also add polarion flags --test-suite-params="$POLARION_TEST_SUITE_PARAMS" and general e2e test args E2E_TEST_ARGS?

phoracek commented 4 years ago

OVS CNI is not linked in polarion, so we don't need that flag.

E2E args would be useful to play with ginkgo arguments. e.g. we may want to disable colors on Prow.

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment