k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Fix Link Error in deployment-on-arbitrary-cluster.md #127

Closed vanou closed 4 years ago

vanou commented 4 years ago

This commit fixes wrong URL in docs/deployment-on-arbitrary-cluster.md

kubevirt-bot commented 4 years ago

Hi @vanou. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

Looks good, thanks @vanou

We require commits to be signed. Would you please amend the commit with git commit -s -amend and force push it again?

vanou commented 4 years ago

Thanks @phoracek ! I signed my commit & amended commit.

phoracek commented 4 years ago

Thanks a lot :rocket:

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, vanou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vanou commented 4 years ago

/release-note-none